From owner-freebsd-current@FreeBSD.ORG Thu Jul 30 13:32:05 2009 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 11C2D1065673; Thu, 30 Jul 2009 13:32:05 +0000 (UTC) (envelope-from serenity@exscape.org) Received: from ch-smtp01.sth.basefarm.net (ch-smtp01.sth.basefarm.net [80.76.149.212]) by mx1.freebsd.org (Postfix) with ESMTP id 880258FC16; Thu, 30 Jul 2009 13:32:04 +0000 (UTC) (envelope-from serenity@exscape.org) Received: from c83-253-252-234.bredband.comhem.se ([83.253.252.234]:55670 helo=mx.exscape.org) by ch-smtp01.sth.basefarm.net with esmtp (Exim 4.68) (envelope-from ) id 1MWVjj-0007SM-4P; Thu, 30 Jul 2009 15:32:01 +0200 Received: from [192.168.1.5] (macbookpro [192.168.1.5]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by mx.exscape.org (Postfix) with ESMTPSA id 50FB6173529; Thu, 30 Jul 2009 15:32:00 +0200 (CEST) Message-Id: <19347561-3CE6-40B3-930A-EB9925D3AFD1@exscape.org> From: Thomas Backman To: Andriy Gapon In-Reply-To: <4A719CA4.4060400@freebsd.org> Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Mime-Version: 1.0 (Apple Message framework v935.3) Date: Thu, 30 Jul 2009 15:31:58 +0200 References: <20090727072503.GA52309@jpru.ffm.jpru.de> <4A6E06E6.9030300@mail.zedat.fu-berlin.de> <4A6EC9E2.5070200@icyb.net.ua> <20090729084723.GD1586@garage.freebsd.pl> <4A7030B6.8010205@icyb.net.ua> <97D5950F-4E4D-4446-AC22-92679135868D@exscape.org> <4A7048A9.4020507@icyb.net.ua> <52AA86CB-6C06-4370-BA73-CE19175467D0@exscape.org> <4A705299.8060504@icyb.net.ua> <4A7054E1.5060402@icyb.net.ua> <5918824D-A67C-43E6-8685-7B72A52B9CAE@exscape.org> <4A705E50.8070307@icyb.net.ua> <4A70728C.7020004@freebsd.org> <6D47A34B-0753-4CED-BF3D-C505B37748FC@exscape.org> <4A708455.5070304@freebsd.org> <86983A55-E5C4-4C04-A4C7-0AE9A9EE37A3@exscape.org> <4A718E03.6030909@freebsd.org> <71A038EC-02B1-4606-96C2-5E84BE80F005@exscape.org> <4A719CA4.4060400@freebsd.org> X-Mailer: Apple Mail (2.935.3) X-Originating-IP: 83.253.252.234 X-Scan-Result: No virus found in message 1MWVjj-0007SM-4P. X-Scan-Signature: ch-smtp01.sth.basefarm.net 1MWVjj-0007SM-4P a695d8c928608426409cbd7444cdc9d4 Cc: freebsd-fs@freebsd.org, FreeBSD current , Pawel Jakub Dawidek Subject: Re: zfs: Fatal trap 12: page fault while in kernel mode X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Jul 2009 13:32:05 -0000 On Jul 30, 2009, at 15:14, Andriy Gapon wrote: > Thomas, > > I wasn't clear - please make sure that you have original > zfs_inactive (without the > changes that Pawel proposed) with the only change zfs_znode_free -> > vrecycle. > I.e.: > if (zp->z_dbuf == NULL) { > /* > * The fs has been unmounted, or we did a > * suspend/resume and this file no longer exists. > */ > mutex_enter(&zp->z_lock); > VI_LOCK(vp); > vp->v_count = 0; /* count arrives as 1 */ > mutex_exit(&zp->z_lock); > rw_exit(&zfsvfs->z_teardown_inactive_lock); > vrecycle(vp, curthread); > return; > } > > I believe that the latest panic is a direct result of ZTOV(zp) = > NULL line > introduced in zfs_vnops.c.2.patch. > > reclaim function should stay patched with Pawel's patch. Hey, it works!!! :) For the first time ever, my now mislabeled "clone_crash.sh" doesn't panic! A quick test of my ordinary, actually-used backup script also worked fine! For the record, here's the diff I got: http://exscape.org/temp/zfs_vnops.c.patch Thanks a lot! Hope to see this tested further (I'll do some more testing for sure) so that we can consider it a stable change. Regards, Thomas