From owner-freebsd-ports-bugs@FreeBSD.ORG Tue Jan 29 22:00:00 2013 Return-Path: Delivered-To: freebsd-ports-bugs@smarthost.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id B7ECD616 for ; Tue, 29 Jan 2013 22:00:00 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) by mx1.freebsd.org (Postfix) with ESMTP id 87C46A7D for ; Tue, 29 Jan 2013 22:00:00 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.6/8.14.6) with ESMTP id r0TM00Li026461 for ; Tue, 29 Jan 2013 22:00:00 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.6/8.14.6/Submit) id r0TM00Qh026460; Tue, 29 Jan 2013 22:00:00 GMT (envelope-from gnats) Resent-Date: Tue, 29 Jan 2013 22:00:00 GMT Resent-Message-Id: <201301292200.r0TM00Qh026460@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Glen Barber Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id 4FB6C5F8 for ; Tue, 29 Jan 2013 21:58:17 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22]) by mx1.freebsd.org (Postfix) with ESMTP id 3D197A6B for ; Tue, 29 Jan 2013 21:58:17 +0000 (UTC) Received: from red.freebsd.org (localhost [127.0.0.1]) by red.freebsd.org (8.14.5/8.14.5) with ESMTP id r0TLwGLZ066918 for ; Tue, 29 Jan 2013 21:58:16 GMT (envelope-from nobody@red.freebsd.org) Received: (from nobody@localhost) by red.freebsd.org (8.14.5/8.14.5/Submit) id r0TLwGqK066917; Tue, 29 Jan 2013 21:58:16 GMT (envelope-from nobody) Message-Id: <201301292158.r0TLwGqK066917@red.freebsd.org> Date: Tue, 29 Jan 2013 21:58:16 GMT From: Glen Barber To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Subject: ports/175684: [patch] emulators/virtualbox-ose-kmod: Fix KMODDIR installation X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 29 Jan 2013 22:00:00 -0000 >Number: 175684 >Category: ports >Synopsis: [patch] emulators/virtualbox-ose-kmod: Fix KMODDIR installation >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Tue Jan 29 22:00:00 UTC 2013 >Closed-Date: >Last-Modified: >Originator: Glen Barber >Release: 10.0-CURRENT r245748M >Organization: >Environment: FreeBSD nucleus 10.0-CURRENT FreeBSD 10.0-CURRENT #57 r245748M: Mon Jan 28 10:32:02 EST 2013 gjb@nucleus:/usr/obj/usr/src/sys/NUCLEUS amd64 >Description: emulators/virtualbox-ose-kmod/Makefile sets KMODDIR to /boot/modules if not set: root@nucleus:/usr/ports/emulators/virtualbox-ose-kmod # grep ^KMODDIR Makefile KMODDIR?= /boot/modules However, KMODDIR is always set, even if not explicitly set by the user: root@nucleus:/usr/ports/emulators/virtualbox-ose-kmod # make -V KMODDIR /boot/kernel root@nucleus:/usr/ports/emulators/virtualbox-ose-kmod # make -C ../qemu -V KMODDIR /boot/kernel >How-To-Repeat: >Fix: The attached patch sets KMODDIR=/boot/modules instead of attempting to set to /boot/modules if not set, otherwise users will experience pain when vbox*.ko disappear after a kernel upgrade. Patch attached with submission follows: Index: /usr/ports/emulators/virtualbox-ose-kmod/Makefile =================================================================== --- /usr/ports/emulators/virtualbox-ose-kmod/Makefile (revision 311188) +++ /usr/ports/emulators/virtualbox-ose-kmod/Makefile (working copy) @@ -45,7 +45,7 @@ PLIST_SUB+= KMODDIR=${KMODDIR:C,^/,,} -KMODDIR?= /boot/modules +KMODDIR= /boot/modules SRC_BASE?= /usr/src VBOX_BIN= ${WRKSRC}/out/${KMK_ARCH}/${KMK_BUILDTYPE}/bin/src >Release-Note: >Audit-Trail: >Unformatted: