From owner-freebsd-ports-bugs@freebsd.org Tue Dec 5 22:51:09 2017 Return-Path: Delivered-To: freebsd-ports-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 5F461E85B79 for ; Tue, 5 Dec 2017 22:51:09 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4429C76A5F for ; Tue, 5 Dec 2017 22:51:09 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id vB5Mp8aE094702 for ; Tue, 5 Dec 2017 22:51:09 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 224135] [net-mgmt/netdata] Spurious errors regarding PID 0 logged every second Date: Tue, 05 Dec 2017 22:51:09 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: nhoyle@hoyletech.com X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: mmokhi@freebsd.org X-Bugzilla-Flags: maintainer-feedback? X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter flagtypes.name Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Dec 2017 22:51:09 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D224135 Bug ID: 224135 Summary: [net-mgmt/netdata] Spurious errors regarding PID 0 logged every second Product: Ports & Packages Version: Latest Hardware: Any OS: Any Status: New Severity: Affects Many People Priority: --- Component: Individual Port(s) Assignee: mmokhi@freebsd.org Reporter: nhoyle@hoyletech.com Assignee: mmokhi@freebsd.org Flags: maintainer-feedback?(mmokhi@freebsd.org) When the apps.plugin plugins are enabled (as is common), netdata logs an er= ror every single poll (1 second by default) to /var/log/netdata/error.log in regards to PID 0 [kernel], like such: 2017-12-05 17:13:11: apps.plugin ERROR: Invalid pid 0 read (expected 1 to 99999). Ignoring process. 2017-12-05 17:13:12: apps.plugin ERROR: Invalid pid 0 read (expected 1 to 99999). Ignoring process. 2017-12-05 17:13:13: apps.plugin ERROR: Invalid pid 0 read (expected 1 to 99999). Ignoring process. 2017-12-05 17:13:14: apps.plugin ERROR: Invalid pid 0 read (expected 1 to 99999). Ignoring process. 2017-12-05 17:13:15: apps.plugin ERROR: Invalid pid 0 read (expected 1 to 99999). Ignoring process. 2017-12-05 17:13:16: apps.plugin ERROR: Invalid pid 0 read (expected 1 to 99999). Ignoring process. 2017-12-05 17:13:17: apps.plugin ERROR: Invalid pid 0 read (expected 1 to 99999). Ignoring process. 2017-12-05 17:13:18: apps.plugin ERROR: Invalid pid 0 read (expected 1 to 99999). Ignoring process. 2017-12-05 17:13:19: apps.plugin ERROR: Invalid pid 0 read (expected 1 to 99999). Ignoring process. 2017-12-05 17:13:20: apps.plugin ERROR: Invalid pid 0 read (expected 1 to 99999). Ignoring process. 2017-12-05 17:13:21: apps.plugin ERROR: Invalid pid 0 read (expected 1 to 99999). Ignoring process. 2017-12-05 17:13:22: apps.plugin ERROR: Invalid pid 0 read (expected 1 to 99999). Ignoring process. 2017-12-05 17:13:23: apps.plugin ERROR: Invalid pid 0 read (expected 1 to 99999). Ignoring process. 2017-12-05 17:13:24: apps.plugin ERROR: Invalid pid 0 read (expected 1 to 99999). Ignoring process. 2017-12-05 17:13:25: apps.plugin ERROR: Invalid pid 0 read (expected 1 to 99999). Ignoring process. 2017-12-05 17:13:26: apps.plugin ERROR: Invalid pid 0 read (expected 1 to 99999). Ignoring process. 2017-12-05 17:13:27: apps.plugin ERROR: Invalid pid 0 read (expected 1 to 99999). Ignoring process. 2017-12-05 17:13:28: apps.plugin ERROR: Invalid pid 0 read (expected 1 to 99999). Ignoring process. This appears to be based on a Linux-centric assumption that 1 will be the lowest observed PID. Because of the logging rate, this quickly triggers the following as well: 2017-12-05 17:13:29: apps.plugin Too many logs (101 logs in 100 seconds, threshold is set to 100 logs in 3600 seconds). Preventing more logs from process 'apps.plugin' for 3500 seconds. Which may result in more valuable logs being suppressed. I have traced this flawed check to the "collect_data_for_pid" function in apps_plugin.c, with = the following code: void collect_data_for_pid(pid_t pid) { if(unlikely(pid <=3D 0 || pid > pid_max)) { error("Invalid pid %d read (expected 1 to %d). Ignoring process.", = pid, pid_max); return; } I have reported this issue to the upstream github project at https://github.com/firehol/netdata/issues/3099, but a FreeBSD port fix woul= d be welcome until this is addressed upstream. --=20 You are receiving this mail because: You are the assignee for the bug.=