From owner-svn-ports-head@FreeBSD.ORG  Mon Dec 10 08:44:43 2012
Return-Path: <owner-svn-ports-head@FreeBSD.ORG>
Delivered-To: svn-ports-head@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 1033)
 id 7E982143; Mon, 10 Dec 2012 08:44:43 +0000 (UTC)
Date: Mon, 10 Dec 2012 08:44:43 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: Thierry Thomas <thierry@FreeBSD.org>
Subject: Re: svn commit: r308470 - head/x11/rxvt-unicode
Message-ID: <20121210084443.GC34139@FreeBSD.org>
References: <201212081017.qB8AHfHF018626@svn.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=koi8-r
Content-Disposition: inline
In-Reply-To: <201212081017.qB8AHfHF018626@svn.freebsd.org>
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org,
 ports-committers@freebsd.org
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 10 Dec 2012 08:44:43 -0000

On Sat, Dec 08, 2012 at 10:17:41AM +0000, Thierry Thomas wrote:
> New Revision: 308470
> URL: http://svnweb.freebsd.org/changeset/ports/308470
> 
> @@ -1,9 +1,5 @@
> -# New ports collection Makefile for: rxvt
> -# Date created:         5th December 1994
>  # Whom:                 gpalmer@FreeBSD.org
> -#
>  # $FreeBSD$
> -#

This is incorrect header format.  s/Whom:[[:blank:]]*/Created by: /

> +PERL_DESC=		Embedded Perl interpreter
> +XIM_DESC=		Support for XIM (X Input Method) protocol
> +UNICODE3_DESC=		Support Unicode codepoints above 65535
> +ISO14755_DESC=		Support for extended ISO 14755 modes
> +COMBINING_DESC=		Automatic composition of combining chars
> +RXVT_SCROLLBAR_DESC=	Support for the original rxvt scrollbar
> +NEXT_SCROLLBAR_DESC=	Support for a NeXT-like scrollbar
> +XTERM_SCROLLBAR_DESC=	Support for an Xterm-like scrollbar
> +BACKSPACE_KEY_DESC=	Handling of the backspace key by rxvt
> +DELETE_KEY_DESC=	Handling of the delete key by rxvt
> +MOUSEWHEEL_DESC=	Support for scrolling via mouse wheel
> +SMART_RESIZE_DESC=	Smart growth/shrink behaviour
> +IMLOCALE_FIX_DESC=	imlocale encoding conversion fix
> +GDK_PIXBUF_DESC=	Use gdk-pixbuf for background images
> +AFTERIMAGE_DESC=	Use libAfterImage for background images
> +NOTIFY_DESC=		Freedesktop startup notification support
> +256_COLOR_DESC=		Support for 256 colors

Most of these should be reworded to have "support" word at the end.  See
examples in the port.options.desc.mk.

./danfe