From owner-cvs-all@FreeBSD.ORG Tue Apr 29 11:00:34 2003 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id AB61B37B401; Tue, 29 Apr 2003 11:00:34 -0700 (PDT) Received: from khavrinen.lcs.mit.edu (khavrinen.lcs.mit.edu [18.24.4.193]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7CEA843FB1; Tue, 29 Apr 2003 11:00:31 -0700 (PDT) (envelope-from wollman@khavrinen.lcs.mit.edu) Received: from khavrinen.lcs.mit.edu (localhost [IPv6:::1]) by khavrinen.lcs.mit.edu (8.12.9/8.12.9) with ESMTP id h3TI0DSq040245 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 29 Apr 2003 14:00:13 -0400 (EDT) (envelope-from wollman@khavrinen.lcs.mit.edu) Received: (from wollman@localhost) by khavrinen.lcs.mit.edu (8.12.9/8.12.9/Submit) id h3TI0Dnr040242; Tue, 29 Apr 2003 14:00:13 -0400 (EDT) (envelope-from wollman) Date: Tue, 29 Apr 2003 14:00:13 -0400 (EDT) From: Garrett Wollman Message-Id: <200304291800.h3TI0Dnr040242@khavrinen.lcs.mit.edu> To: "M. Warner Losh" In-Reply-To: <20030429.115524.21927823.imp@bsdimp.com> References: <200304290545.h3T5j99Y076513@repoman.freebsd.org> <20030429133708.A84234@grasshopper.cs.duke.edu> <20030429.115524.21927823.imp@bsdimp.com> X-Scanned-By: MIMEDefang 2.33 (www . roaringpenguin . com / mimedefang) cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: gallatin@cs.duke.edu cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/fxp if_fxp.c if_fxpvar.h X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 29 Apr 2003 18:00:35 -0000 < said: > This likely means that some higher level of locking is necessary so > that we can make sure that the interrupts can't happen once detach > starts. What am I missing here? You can just disable interrupts in the hardware first thing, while holding whatever lock the handler would normally need to obtain, then force-terminate the handler thread if it happens to be waiting for that lock after you're done tearing it down. -GAWollman