From owner-p4-projects@FreeBSD.ORG Sun Jun 20 19:59:22 2004 Return-Path: Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id DD37416A4D0; Sun, 20 Jun 2004 19:59:21 +0000 (GMT) Delivered-To: perforce@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B09F816A4CE for ; Sun, 20 Jun 2004 19:59:21 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id A95D143D1F for ; Sun, 20 Jun 2004 19:59:21 +0000 (GMT) (envelope-from julian@freebsd.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i5KJxFM0045108 for ; Sun, 20 Jun 2004 19:59:15 GMT (envelope-from julian@freebsd.org) Received: (from perforce@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i5KJxFxT045105 for perforce@freebsd.org; Sun, 20 Jun 2004 19:59:15 GMT (envelope-from julian@freebsd.org) Date: Sun, 20 Jun 2004 19:59:15 GMT Message-Id: <200406201959.i5KJxFxT045105@repoman.freebsd.org> X-Authentication-Warning: repoman.freebsd.org: perforce set sender to julian@freebsd.org using -f From: Julian Elischer To: Perforce Change Reviews Subject: PERFORCE change 55393 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 20 Jun 2004 19:59:22 -0000 http://perforce.freebsd.org/chv.cgi?CH=55393 Change 55393 by julian@julian_desk on 2004/06/20 19:59:07 Set teh "had threads" flag down when doign exec or exit, and ensure everything actually looks that way. {this chamge still not tested}. Affected files ... .. //depot/projects/nsched/sys/kern/kern_exec.c#5 edit .. //depot/projects/nsched/sys/kern/kern_exit.c#10 edit .. //depot/projects/nsched/sys/kern/kern_fork.c#5 edit .. //depot/projects/nsched/sys/kern/kern_kse.c#14 edit Differences ... ==== //depot/projects/nsched/sys/kern/kern_exec.c#5 (text+ko) ==== @@ -263,8 +263,14 @@ /* * If we get here all other threads are dead, * so unset the associated flags and lose KSE mode. + * This meams that we must get rid of any extra + * upcalls and kses we may have picked up along the way. */ - p->p_flag &= ~P_SA; + mtx_lock_spin(&sched_lock): + sched_set_concurrancy(td, 1); + upcall_remove(td); + mtx_unlock_spin(&sched_lock): + p->p_flag &= ~(P_SA|P_HADTHREADS); td->td_mailbox = NULL; td->td_pflags &= ~TDP_SA; thread_single_end(); ==== //depot/projects/nsched/sys/kern/kern_exit.c#10 (text+ko) ==== @@ -167,9 +167,14 @@ * ... * Turn off threading support. */ - p->p_flag &= ~P_SA; + mtx_lock_spin(&sched_lock): + sched_set_concurrancy(td, 1); + upcall_remove(td); + mtx_unlock_spin(&sched_lock): + p->p_flag &= ~(P_SA|P_HADTHREADS); + td->td_mailbox = NULL; td->td_pflags &= ~TDP_SA; - thread_single_end(); /* end single-threading mode */ + thread_single_end(); } p->p_flag |= P_WEXIT; ==== //depot/projects/nsched/sys/kern/kern_fork.c#5 (text+ko) ==== ==== //depot/projects/nsched/sys/kern/kern_kse.c#14 (text+ko) ====