From owner-svn-src-stable@FreeBSD.ORG Thu Mar 26 13:27:27 2009 Return-Path: Delivered-To: svn-src-stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 05F5F1065674; Thu, 26 Mar 2009 13:27:27 +0000 (UTC) (envelope-from bz@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c]) by mx1.freebsd.org (Postfix) with ESMTP id E60008FC0A; Thu, 26 Mar 2009 13:27:26 +0000 (UTC) (envelope-from bz@FreeBSD.org) Received: from svn.freebsd.org (localhost [127.0.0.1]) by svn.freebsd.org (8.14.3/8.14.3) with ESMTP id n2QDRQAI018935; Thu, 26 Mar 2009 13:27:26 GMT (envelope-from bz@svn.freebsd.org) Received: (from bz@localhost) by svn.freebsd.org (8.14.3/8.14.3/Submit) id n2QDRQEr018934; Thu, 26 Mar 2009 13:27:26 GMT (envelope-from bz@svn.freebsd.org) Message-Id: <200903261327.n2QDRQEr018934@svn.freebsd.org> From: "Bjoern A. Zeeb" Date: Thu, 26 Mar 2009 13:27:26 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-7@freebsd.org X-SVN-Group: stable-7 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Subject: svn commit: r190441 - in stable/7/sys: . contrib/pf dev/ath/ath_hal dev/cxgb netinet X-BeenThere: svn-src-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for all the -stable branches of the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Mar 2009 13:27:27 -0000 Author: bz Date: Thu Mar 26 13:27:26 2009 New Revision: 190441 URL: http://svn.freebsd.org/changeset/base/190441 Log: MFC r184097: Update a comment which to my reading had been misplaced in rev. 1.12 already (but probably had been way above as the code was there twice) and describe what was last changed in rev. 1.199 there (which now is in sync with in6_src.c r184096(HEAD), r189956(stable/7)). Approved by: re (rwatson) Modified: stable/7/sys/ (props changed) stable/7/sys/contrib/pf/ (props changed) stable/7/sys/dev/ath/ath_hal/ (props changed) stable/7/sys/dev/cxgb/ (props changed) stable/7/sys/netinet/in_pcb.c Modified: stable/7/sys/netinet/in_pcb.c ============================================================================== --- stable/7/sys/netinet/in_pcb.c Thu Mar 26 13:22:29 2009 (r190440) +++ stable/7/sys/netinet/in_pcb.c Thu Mar 26 13:27:26 2009 (r190441) @@ -440,8 +440,9 @@ in_pcbbind_setup(struct inpcb *inp, stru if (pcbinfo != &udbinfo) ipport_tcpallocs++; /* - * Simple check to ensure all ports are not used up causing - * a deadlock here. + * Instead of having two loops further down counting up or down + * make sure that first is always <= last and go with only one + * code path implementing all logic. * * We split the two cases (up and down) so that the direction * is not being tested on each round of the loop.