From owner-freebsd-bugs@FreeBSD.ORG  Tue Jan 31 14:37:02 2006
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
X-Original-To: freebsd-bugs@FreeBSD.org
Delivered-To: freebsd-bugs@FreeBSD.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 455D316A422;
	Tue, 31 Jan 2006 14:37:02 +0000 (GMT)
	(envelope-from yar@comp.chem.msu.su)
Received: from comp.chem.msu.su (comp.chem.msu.su [158.250.32.97])
	by mx1.FreeBSD.org (Postfix) with ESMTP id E27BC43D55;
	Tue, 31 Jan 2006 14:36:53 +0000 (GMT)
	(envelope-from yar@comp.chem.msu.su)
Received: from comp.chem.msu.su (localhost [127.0.0.1])
	by comp.chem.msu.su (8.13.3/8.13.3) with ESMTP id k0VEandV036147;
	Tue, 31 Jan 2006 17:36:49 +0300 (MSK)
	(envelope-from yar@comp.chem.msu.su)
Received: (from yar@localhost)
	by comp.chem.msu.su (8.13.3/8.13.3/Submit) id k0VEamoF036143;
	Tue, 31 Jan 2006 17:36:49 +0300 (MSK) (envelope-from yar)
Date: Tue, 31 Jan 2006 17:36:48 +0300
From: Yar Tikhiy <yar@comp.chem.msu.su>
To: Poul-Henning Kamp <phk@phk.freebsd.dk>
Message-ID: <20060131143648.GA34373@comp.chem.msu.su>
References: <200601311410.k0VEAASn057130@freefall.freebsd.org>
	<1198.1138716960@critter.freebsd.dk>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1198.1138716960@critter.freebsd.dk>
User-Agent: Mutt/1.5.9i
Cc: alc@FreeBSD.org, freebsd-bugs@FreeBSD.org
Subject: Re: kern/92243: sendfile(2) returns early on files > 4GB
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 31 Jan 2006 14:37:02 -0000

On Tue, Jan 31, 2006 at 02:16:00PM +0000, Poul-Henning Kamp wrote:
> In message <200601311410.k0VEAASn057130@freefall.freebsd.org>, Yar Tikhiy write
> s:
> 
> > Quite curiously, changing the type of the size argument to
> > vnode_create_vobject() from size_t to off_t seems to remedy the
> > problem in my case.  Let's ask Poul-Henning, who introduced the
> > kernel function a year ago, what he thinks about this -- adding him
> > to CC.
> 
> Oversight on my part.

My last concern is whether off_t is correct there, or it should be
vm_ooffset_t.  I.e., should the size argument represent a file size
or VM object size?  As a matter of fact, the size argument is
transformed into vm_ooffset_t inside vnode_create_vobject(), so we
can safely decide that vnode_create_vobject() is on the vnode side
of the vnode-VM interface.  Thanks!

-- 
Yar