From owner-svn-src-all@freebsd.org  Mon Apr 18 17:48:41 2016
Return-Path: <owner-svn-src-all@freebsd.org>
Delivered-To: svn-src-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id BFDC9B13607
 for <svn-src-all@mailman.ysv.freebsd.org>;
 Mon, 18 Apr 2016 17:48:41 +0000 (UTC) (envelope-from ian@freebsd.org)
Received: from outbound1b.ore.mailhop.org (outbound1b.ore.mailhop.org
 [54.200.247.200])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 8255316F3
 for <svn-src-all@freebsd.org>; Mon, 18 Apr 2016 17:48:41 +0000 (UTC)
 (envelope-from ian@freebsd.org)
X-MHO-User: ceb4f599-058d-11e6-8bda-c73aafa13d19
X-Report-Abuse-To: https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information
X-Originating-IP: 73.34.117.227
X-Mail-Handler: DuoCircle Outbound SMTP
Received: from ilsoft.org (unknown [73.34.117.227])
 by outbound1.ore.mailhop.org (Halon Mail Gateway) with ESMTPSA;
 Mon, 18 Apr 2016 17:48:49 +0000 (UTC)
Received: from rev (rev [172.22.42.240])
 by ilsoft.org (8.15.2/8.14.9) with ESMTP id u3IHmcOA033444;
 Mon, 18 Apr 2016 11:48:38 -0600 (MDT) (envelope-from ian@freebsd.org)
Message-ID: <1461001718.52955.50.camel@freebsd.org>
Subject: Re: svn commit: r298199 - head/sys/netinet
From: Ian Lepore <ian@freebsd.org>
To: Michael Tuexen <tuexen@freebsd.org>
Cc: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Date: Mon, 18 Apr 2016 11:48:38 -0600
In-Reply-To: <B6213F78-613D-4B03-9414-65E43782A18A@freebsd.org>
References: <201604180929.u3I9TEA3095105@repo.freebsd.org>
 <1460992202.52955.49.camel@freebsd.org>
 <B6213F78-613D-4B03-9414-65E43782A18A@freebsd.org>
Content-Type: text/plain; charset="us-ascii"
X-Mailer: Evolution 3.16.5 FreeBSD GNOME Team Port 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.21
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 18 Apr 2016 17:48:41 -0000

On Mon, 2016-04-18 at 18:58 +0200, Michael Tuexen wrote:
> > On 18 Apr 2016, at 17:10, Ian Lepore <ian@FreeBSD.org> wrote:
> > 
> > On Mon, 2016-04-18 at 09:29 +0000, Michael Tuexen wrote:
> > > Author: tuexen
> > > Date: Mon Apr 18 09:29:14 2016
> > > New Revision: 298199
> > > URL: https://svnweb.freebsd.org/changeset/base/298199
> > > 
> > > Log:
> > >  Put panic() calls under INVARIANTS.
> > > 
> > 
> > A panic that's only active when INVARIANTS is defined is usually
> > spelled KASSERT.
> OK. The change happens because when using the code in the userland
> SCTP stack, we don't provide a panic() replacement unless we
> compile the INVARIANTS defined. Therefore I catch this when compiling
> the userland stack...
> 
> Best regards
> Michael
> > 

Ahh, no KASSERT in userland, thanks.  I probably could have figured
that out for myself if I had put a bit of effort into looking.

-- Ian