Date: Sun, 13 Aug 2000 12:28:02 -0500 From: Steve Price <sprice@hiwaay.net> To: alex@freebsd.org Cc: ports@freebsd.org, asami@freebsd.org Subject: Re: cvs commit: ports/games/xsok Makefile Message-ID: <20000813122802.W90230@bonsai.hiwaay.net> In-Reply-To: <20000813121453.U90230@bonsai.hiwaay.net>; from sprice@hiwaay.net on Sun, Aug 13, 2000 at 12:14:53PM -0500 References: <200008131635.JAA13051@freefall.freebsd.org> <20000813183919.B20187@cichlids.cichlids.com> <20000813114249.S90230@bonsai.hiwaay.net> <20000813185728.A23014@cichlids.cichlids.com> <20000813121453.U90230@bonsai.hiwaay.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Aug 13, 2000 at 12:14:53PM -0500, I wrote:
# However I do see how USE_IMAKE won't work in this specific instance.
# I've seen this problem before on my Alpha package building machine and
# the problem wasn't with the port. It had to do with the devel/imake
# port. After this port was built all ports built after it would fail
# for various X-related reasons.
#
# I think the problem might be in the setup of package building machines
# and not with the ports themselves. Having either USE_IMAKE, USE_XLIB,
# or USE_X_PREFIX is enough to guarantee that xmkmf will be installed.
# Something else is amiss and the fixes you are committing are a bandaid
# over another problem. IMHO. :)
Actually upon further review it isn't a problem with the imake port.
It is a problem with the following lines in bsd.port.mk.
.if defined(USE_XLIB)
.if ${XFREE86_VERSION} == 3
# Don't try to build XFree86-3 even if ALWAYS_BUILD_DEPENDS is defined --
# it's just too big....
.if !defined(ALWAYS_BUILD_DEPENDS)
LIB_DEPENDS+= X11.6:${PORTSDIR}/x11/XFree86
.endif
.else
LIB_DEPENDS+= X11.6:${PORTSDIR}/x11/XFree86-4-libraries
.endif
.endif
Since USE_IMAKE implies USE_X_PREFIX implies USE_XLIB you can't always
assume that USE_XLIB only ever means you want just the X libraries.
Applying the following patch should fix all the problems that the
package building cluster is seeing. Note this is only a quick fix.
Index: bsd.port.mk
===================================================================
RCS file: /home/ncvs/ports/Mk/bsd.port.mk,v
retrieving revision 1.345
diff -u -r1.345 bsd.port.mk
--- bsd.port.mk 2000/08/03 09:28:57 1.345
+++ bsd.port.mk 2000/08/13 17:24:17
@@ -827,7 +827,7 @@
LIB_DEPENDS+= X11.6:${PORTSDIR}/x11/XFree86
.endif
.else
-LIB_DEPENDS+= X11.6:${PORTSDIR}/x11/XFree86-4-libraries
+LIB_DEPENDS+= X11.6:${PORTSDIR}/x11/XFree86-4
.endif
.endif
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20000813122802.W90230>