From owner-svn-ports-all@FreeBSD.ORG Sun Nov 16 11:35:30 2014 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 277E5220; Sun, 16 Nov 2014 11:35:30 +0000 (UTC) Received: from mail-wg0-x235.google.com (mail-wg0-x235.google.com [IPv6:2a00:1450:400c:c00::235]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id B88A5CB6; Sun, 16 Nov 2014 11:35:29 +0000 (UTC) Received: by mail-wg0-f53.google.com with SMTP id b13so22674153wgh.40 for ; Sun, 16 Nov 2014 03:35:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=flBfxQOCOoWCTozws72mXQHTf56vwkwbxA8DQ93XA5g=; b=lxl/yZNssKdZi2ezE2cxaA5sJfV2HzLiIjWgmPyl4p0yauVqhlk9FqTXGdivuOBZD/ 2TplaVtoJpCmD7R4+qRaxByOyjhA2siQjb0ZRlwcf0NZllluXgqwyf4nWjo5CYoUVRZ2 D6kqWvDnHm6TQaJobaM/lst6YzU6ToB5ie3gvziULeh6sRn98BMP2bdiOk4YMuaxE2GK mHVGAvNKDcDKq0SlZ6RF9UGegqY36uLS7kaHDMqMIknGSR0FcbQqe1oks5LkZKPzDeg9 iwvwgizFB46y8jY9gMH/V9cceU6MWKQhUxQ7M8rbilxEqHg/AKChU2d9OQ9L8ZDovhll EITw== X-Received: by 10.194.236.232 with SMTP id ux8mr30010050wjc.96.1416137728231; Sun, 16 Nov 2014 03:35:28 -0800 (PST) Received: from ivaldir.etoilebsd.net ([2001:41d0:8:db4c::1]) by mx.google.com with ESMTPSA id fv5sm4781246wjc.37.2014.11.16.03.35.26 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 16 Nov 2014 03:35:27 -0800 (PST) Sender: Baptiste Daroussin Date: Sun, 16 Nov 2014 12:35:25 +0100 From: Baptiste Daroussin To: Mathieu Arnold Subject: Re: svn commit: r372622 - in head/editors/vim: . files Message-ID: <20141116113525.GH45145@ivaldir.etoilebsd.net> References: <201411160232.sAG2WJ4Z084790@svn.freebsd.org> <54687C89.20206@gmx.de> <20141116113345.GG45145@ivaldir.etoilebsd.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="4C6bbPZ6c/S1npyF" Content-Disposition: inline In-Reply-To: <20141116113345.GG45145@ivaldir.etoilebsd.net> User-Agent: Mutt/1.5.23 (2014-03-12) Cc: svn-ports-head@freebsd.org, Olli Hauer , svn-ports-all@freebsd.org, Alfred Perlstein , ports-committers@freebsd.org X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 16 Nov 2014 11:35:30 -0000 --4C6bbPZ6c/S1npyF Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Nov 16, 2014 at 12:33:45PM +0100, Baptiste Daroussin wrote: > On Sun, Nov 16, 2014 at 12:24:04PM +0100, Mathieu Arnold wrote: > > +--On 16 novembre 2014 11:29:29 +0100 olli hauer wrote: > > |> +.if ${PORT_OPTIONS:MDEFAULT_VIMRC} > > |> + ${INSTALL_DATA} ${FILESDIR}/vimrc > > |> ${STAGEDIR}${DEFAULT_VIMRC_LOCATION}/vimrc +.endif > > |> =20 > > | ... > > |=20 > > | Thanks for installing a default vimrc file, but isn't it safer to ins= tall > > | the vimrc file with the @sample macro to protect users having already= a > > | own vimrc file installed? > >=20 > > Yes, please, install a .sample file and use @sample in the plist, you're > > going to overwrite people's existing vimrc. > >=20 > I first asked alfred to do such before the commit. >=20 > But when looking at how vim handles vimrc this is a fallback location hen= ce this > vimrc is only loaded only if there is no user supplied vimrc >=20 > ':version' will show you: > system vimrc file: "$VIM/vimrc" > user vimrc file: "$HOME/.vimrc" > 2nd user vimrc file: "~/.vim/vimrc" > user exrc file: "$HOME/.exrc" > fall-back for $VIM: "/usr/local/share/vim" >=20 > So now I'm thinking there is no need for a @sample ...vimrc.sample given = this > vimrc is doing to be installed in the fall-back location. >=20 > But I do not think adding yet another option is worth, it should probably= always > be installed. >=20 > Regards, > Bapt That said isn't using the default upstream provided vimrc a better option t= han a custom one? /usr/local/share/vim/vim74/vimrc_example.vim as vimrc and probably /usr/local/share/vim/vim74/gvimrc_example.vim as gvimrc? Best regards, Bapt --4C6bbPZ6c/S1npyF Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlRoi/0ACgkQ8kTtMUmk6ExvCgCfT/ElT4nhSKAnTboF3YYKW8GT 2/YAnAlCIn1cqVwpM7XPBKm8uJKOAiyQ =+M2p -----END PGP SIGNATURE----- --4C6bbPZ6c/S1npyF--