From owner-cvs-all  Tue Nov 27 14:34:50 2001
Delivered-To: cvs-all@freebsd.org
Received: from mail12.speakeasy.net (mail12.speakeasy.net [216.254.0.212])
	by hub.freebsd.org (Postfix) with ESMTP id 83E0137B41A
	for <cvs-all@FreeBSD.org>; Tue, 27 Nov 2001 14:34:38 -0800 (PST)
Received: (qmail 32268 invoked from network); 27 Nov 2001 22:34:35 -0000
Received: from unknown (HELO laptop.baldwin.cx) ([64.81.54.73]) (envelope-sender <jhb@FreeBSD.org>)
          by mail12.speakeasy.net (qmail-ldap-1.03) with SMTP
          for <sobomax@FreeBSD.org>; 27 Nov 2001 22:34:35 -0000
Message-ID: <XFMail.011127143423.jhb@FreeBSD.org>
X-Mailer: XFMail 1.4.0 on FreeBSD
X-Priority: 3 (Normal)
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
In-Reply-To: <200111272221.AAA47815@ipcard.iptcom.net>
Date: Tue, 27 Nov 2001 14:34:23 -0800 (PST)
From: John Baldwin <jhb@FreeBSD.org>
To: Maxim Sobolev <sobomax@FreeBSD.org>
Subject: Re: Meaningless commit messages [was: cvs commit: ports/www/linu
Cc: cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org, des@FreeBSD.org,
	mike@FreeBSD.org
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG


On 28-Nov-01 Maxim Sobolev wrote:
> On Tue, 27 Nov 2001 16:35:13 -0500, Mike Barcroft wrote:
>> Maxim Sobolev <sobomax@FreeBSD.org> writes:
>> > On Tue, 27 Nov 2001 09:49:16 -0800 (PST), Dag-Erling Smorgrav wrote:
>> > > des         2001/11/27 09:49:16 PST
>> > > 
>> > >   Modified files:
>> > >     www/linux-opera      Makefile 
>> > >   Log:
>> > >   Pander to the backseat drivers.
>> > 
>> > Could you please use more meaningful commit messages? For
>> > example it is absolutely impossible to guess what this
>> > commit is all about without looking at the diff.
>> 
>> >From the Committers Guide:
>> "Do not waste space in the commit messages explaining what you did.
>> That is what cvs diff is for.  Instead, tell us why you did it."
> 
> So, could you please explain me how from the above log one could
> see "why he did it".

He did it to "pander to the backseat drivers."  Obviously. :)  I think you
missed the sarcasm Mike was using in his original mail.

> -Maxim

-- 

John Baldwin <jhb@FreeBSD.org>  <><  http://www.FreeBSD.org/~jhb/
"Power Users Use the Power to Serve!"  -  http://www.FreeBSD.org/

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message