From owner-cvs-all@FreeBSD.ORG Mon Feb 5 17:31:54 2007 Return-Path: X-Original-To: cvs-all@freebsd.org Delivered-To: cvs-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 4FA3016A401; Mon, 5 Feb 2007 17:31:54 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (66-23-211-162.clients.speedfactory.net [66.23.211.162]) by mx1.freebsd.org (Postfix) with ESMTP id EF18813C4A3; Mon, 5 Feb 2007 17:31:51 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from localhost.corp.yahoo.com (john@localhost [127.0.0.1]) (authenticated bits=0) by server.baldwin.cx (8.13.6/8.13.6) with ESMTP id l15HVneC062782; Mon, 5 Feb 2007 12:31:49 -0500 (EST) (envelope-from jhb@freebsd.org) From: John Baldwin To: Max Laier Date: Mon, 5 Feb 2007 12:13:24 -0500 User-Agent: KMail/1.9.1 References: <200701302354.l0UNsoF4091229@repoman.freebsd.org> <200701311257.56169.jhb@freebsd.org> <200702022027.47269.max@love2party.net> In-Reply-To: <200702022027.47269.max@love2party.net> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200702051213.25656.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [127.0.0.1]); Mon, 05 Feb 2007 12:31:50 -0500 (EST) X-Virus-Scanned: ClamAV 0.88.3/2524/Mon Feb 5 07:48:22 2007 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/kern subr_firmware.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Feb 2007 17:31:54 -0000 On Friday 02 February 2007 14:27, Max Laier wrote: > On Wednesday 31 January 2007 18:57, John Baldwin wrote: > > On Tuesday 30 January 2007 18:54, Max Laier wrote: > > > mlaier 2007-01-30 23:54:50 UTC > > > > > > FreeBSD src repository > > > > > > Modified files: (Branch: RELENG_6) > > > sys/kern subr_firmware.c > > > Log: > > > Revert 1.1.2.2 as linker_release_module is not in RELENG_6. Will > > > have to look for a better way and will compile test "trivial changes" > > > in the future. > > > > Probably trivial to backport the function. > > Do you plan to? Otherwise, I'd just solve it locally like attached. Your > addition of linker_release module is a bit interlocked with the locking > changes and I'd rather not get into that, atm. Oh, hmm, I thought the function could be backported simply w/o all the locking stuff. I'm not so sure it can now though. I think your patch is ok. -- John Baldwin