From owner-freebsd-bugs@FreeBSD.ORG Wed Oct 3 01:00:04 2007 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 24F9716A46C for ; Wed, 3 Oct 2007 01:00:04 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id EBE4D13C494 for ; Wed, 3 Oct 2007 01:00:03 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.1/8.14.1) with ESMTP id l93103hT014594 for ; Wed, 3 Oct 2007 01:00:03 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.1/8.14.1/Submit) id l93103a7014593; Wed, 3 Oct 2007 01:00:03 GMT (envelope-from gnats) Resent-Date: Wed, 3 Oct 2007 01:00:03 GMT Resent-Message-Id: <200710030100.l93103a7014593@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Cy Schubert Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id DF5E416A41A for ; Wed, 3 Oct 2007 00:52:59 +0000 (UTC) (envelope-from Cy.Schubert@komquats.com) Received: from pd2mo1so.prod.shaw.ca (idcmail-mo1so.shaw.ca [24.71.223.10]) by mx1.freebsd.org (Postfix) with ESMTP id C20CE13C45D for ; Wed, 3 Oct 2007 00:52:59 +0000 (UTC) (envelope-from Cy.Schubert@komquats.com) Received: from pd4mr4so.prod.shaw.ca (pd4mr4so-qfe3.prod.shaw.ca [10.0.141.215]) by l-daemon (Sun ONE Messaging Server 6.0 HotFix 1.01 (built Mar 15 2004)) with ESMTP id <0JPB00MOP68L8Y10@l-daemon> for FreeBSD-gnats-submit@FreeBSD.org; Tue, 02 Oct 2007 17:50:45 -0600 (MDT) Received: from pn2ml1so.prod.shaw.ca ([10.0.121.145]) by pd4mr4so.prod.shaw.ca (Sun Java System Messaging Server 6.2-7.05 (built Sep 5 2006)) with ESMTP id <0JPB00DWG68JSQ30@pd4mr4so.prod.shaw.ca> for FreeBSD-gnats-submit@FreeBSD.org; Tue, 02 Oct 2007 17:50:43 -0600 (MDT) Received: from spqr.komquats.com ([24.68.216.215]) by l-daemon (Sun ONE Messaging Server 6.0 HotFix 1.01 (built Mar 15 2004)) with ESMTP id <0JPB00FNH68I19U1@l-daemon> for FreeBSD-gnats-submit@FreeBSD.org; Tue, 02 Oct 2007 17:50:42 -0600 (MDT) Received: from cwsys.cwsent.com (cwsys [10.1.1.1]) by spqr.komquats.com (Postfix) with ESMTP id 48870279C2 for ; Tue, 02 Oct 2007 16:50:38 -0700 (PDT) Received: from cwsys.cwsent.com (localhost [127.0.0.1]) by cwsys.cwsent.com (8.14.1/8.14.1) with ESMTP id l92NobhY030742 for ; Tue, 02 Oct 2007 16:50:37 -0700 Received: (from cy@localhost) by cwsys.cwsent.com (8.14.1/8.13.1/Submit) id l92Nobww030741; Tue, 02 Oct 2007 16:50:37 -0700 (PDT envelope-from cy) Message-Id: <200710022350.l92Nobww030741@cwsys.cwsent.com> Date: Tue, 02 Oct 2007 16:50:37 -0700 (PDT) From: Cy Schubert To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: Subject: bin/116849: dump(8) fails to dump UFS filesystems when nullfs filesyste present X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Cy Schubert List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Oct 2007 01:00:04 -0000 >Number: 116849 >Category: bin >Synopsis: dump(8) fails to dump UFS filesystems when nullfs filesyste present >Confidential: no >Severity: serious >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Wed Oct 03 01:00:03 GMT 2007 >Closed-Date: >Last-Modified: >Originator: Cy Schubert >Release: FreeBSD-2.0 >Organization: FreeBSD >Environment: System: FreeBSD bob 6.2-STABLE FreeBSD 6.2-STABLE #3: Thu Sep 27 16:38:11 PDT 2007 root@cwsys:/export/obj/opt/src/cvs-stable6/src/sys/KOMQUATS i386 >Description: Example fstab: /dev/ad3s1g /dsk01 ufs rw 1 2 [...] /dsk01 /stable5/dsk01 nullfs rw,noauto 0 0 # dump 0f /dev/null /dsk01 dump: unknown filesystem /dsk01 # >How-To-Repeat: See above >Fix: --- sbin/dump/optr.c.orig 2005-02-15 22:48:35.000000000 -0800 +++ sbin/dump/optr.c 2007-10-02 16:33:26.000000000 -0700 @@ -315,9 +315,10 @@ return; } while ((fs = getfsent()) != NULL) { - if (strcmp(fs->fs_type, FSTAB_RW) && + if ((strcmp(fs->fs_type, FSTAB_RW) && strcmp(fs->fs_type, FSTAB_RO) && - strcmp(fs->fs_type, FSTAB_RQ)) + strcmp(fs->fs_type, FSTAB_RQ)) || + strcmp(fs->fs_vfstype, "ufs")) continue; fs = allocfsent(fs); if ((pf = (struct pfstab *)malloc(sizeof (*pf))) == NULL) >Release-Note: >Audit-Trail: >Unformatted: