Date: Thu, 9 Jul 2020 09:16:38 -0700 From: "Simon J. Gerraty" <sjg@juniper.net> To: Cy Schubert <Cy.Schubert@cschubert.com> Cc: <src-committers@FreeBSD.org>, <svn-src-all@FreeBSD.org>, <svn-src-head@FreeBSD.org>, <sjg@juniper.net> Subject: Re: svn commit: r363031 - in head: contrib/bmake contrib/bmake/lst.lib contrib/bmake/mk contrib/bmake/mk/sys contrib/bmake/unit-tests usr.bin/bmake Message-ID: <26265.1594311398@kaos.jnpr.net> In-Reply-To: <202007090402.06942mVr015813@slippy.cwsent.com> References: <202007082120.068LKCeN067904@repo.freebsd.org> <202007090328.0693SNo4028242@slippy.cwsent.com> <45359.1594266432@kaos.jnpr.net> <202007090402.06942mVr015813@slippy.cwsent.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Cy Schubert <Cy.Schubert@cschubert.com> wrote:
> [External Email. Be cautious of content]
>
>
> In message <45359.1594266432@kaos.jnpr.net>, "Simon J. Gerraty" writes:
> > Cy Schubert <Cy.Schubert@cschubert.com> wrote:
> > > This broke ports.
> >
> > I've reverted the change.
> >
> > Let me know if you still see issue.
>
> As I said in my email, all I did was revert cond.c, and that fixed it. You
> don't need to revert the whole patch. Just revert cond.c and let NetBSD
> know.
Ah I missed that bit - rats.
I think I've a fix for cond.c, but unfortunately I'm so far unable to
construct a unit-test that triggers the problem.
Even with bsd.compiler.mk I was unable to get it to fail in debugger,
so added an abort and looked at the core file.
The problem is in something like:
.if 1 || ${something-complicated} > 0
the ${something-complicated} isn't resolved because we do not need to
evaluate anything after '1', but the comparator check is still applied.
Fix should be simple, but in unit-tests the above does not trigger the
problem ;-)
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?26265.1594311398>