Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 21 Jun 2011 09:13:45 -0500
From:      Guy Helmer <guy.helmer@palisadesystems.com>
To:        John Baldwin <jhb@FreeBSD.org>
Cc:        Jack F Vogel <jfv@FreeBSD.org>, svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org
Subject:   Re: svn commit: r223350 - head/sys/dev/e1000
Message-ID:  <5DCAB741-793C-4595-A83D-CC89D9D14A13@palisadesystems.com>
In-Reply-To: <201106210907.18414.jhb@freebsd.org>
References:  <201106202259.p5KMxT1h069297@svn.freebsd.org> <201106210907.18414.jhb@freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help

On Jun 21, 2011, at 8:07 AM, John Baldwin wrote:

> On Monday, June 20, 2011 6:59:29 pm Jack F Vogel wrote:
>> Author: jfv
>> Date: Mon Jun 20 22:59:29 2011
>> New Revision: 223350
>> URL: http://svn.freebsd.org/changeset/base/223350
>>=20
>> Log:
>>  Eliminate some global tuneables in favor of adapter-specific,
>>  particular flow control and dma coalesce. Also improve the
>>  sysctl operation on those too.
>>=20
>>  Add IPv6 detection in the ioctl code, this was done for
>>  ixgbe first, carrying that over.
>>=20
>>  Add resource ability to disable particular adapter.
>>=20
>>  Add HW TSO capability so vlans can make use of TSO
>=20
> The tunables are useful for setting defaults for all interfaces. :(
>=20
> I use hw.igb.rx_processing_limit=3D-1 in loader.conf at work so that =
we can=20
> ensure that all igb interfaces in a given system have that setting.   =
This is=20
> more scalable than having to set the right number of entries in=20
> /etc/sysctl.conf.local on different machines, etc, without spamming =
the=20
> console during boot with warnings about tweaking non-existing sysctls, =
etc.
>=20
> Please consider keeping the tunables where the tunables are used to =
set
> default settings for all adapters from the loader but per-device =
sysctls are
> used post-boot to provide runtime, per-device settings.


I agree.

Guy


--------
This message has been scanned by ComplianceSafe, powered by Palisade's PacketSure.



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5DCAB741-793C-4595-A83D-CC89D9D14A13>