From owner-cvs-ports@FreeBSD.ORG Thu Mar 15 18:13:36 2012 Return-Path: Delivered-To: cvs-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 697CF106564A for ; Thu, 15 Mar 2012 18:13:36 +0000 (UTC) (envelope-from bsd-src@helfman.org) Received: from mail-pz0-f54.google.com (mail-pz0-f54.google.com [209.85.210.54]) by mx1.freebsd.org (Postfix) with ESMTP id 2DA738FC0A for ; Thu, 15 Mar 2012 18:13:36 +0000 (UTC) Received: by dald2 with SMTP id d2so5028011dal.13 for ; Thu, 15 Mar 2012 11:13:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:x-operating-system :organization:x-living-the-dream:x-pgp-fingerprint:x-pgp-key :user-agent:x-gm-message-state; bh=n7aB2JMtmv3PZ5bdVoiLo0wBFLWz6vjOqVYm2jFY0fU=; b=MDJgQk6xJRKx6nVVhHKZUQ3xaB4Er8t5lDUJMwMBnNMX8j+qb72nMsS50JS5MrpFJr q5fM2nkq6XPK4SK1UF05h1Vpo+2BUAhaLjGV3SF9jGSwxOG7q3b7xS4L822NovO5RM+/ qhva2qE9Ag3BjYRyXc9HmHi5lPw4C5GnI99xiyTz3XcpahSvWudsedljUJegeleWV7Ek 94MfP8J8Fr6wJVEFYwnWIQ03hShk/V+iRbJrcuU7+e52Qo0HbNYUQwXMZXrxwGtbFLQ5 JG1vHiaQsFAiU8L9adDR6S6C6E/Z7rLAddp59EmZiLRVlUlUuWFjNV0V/sEvwBCphxid m6hw== Received: by 10.68.135.99 with SMTP id pr3mr6794619pbb.52.1331835215923; Thu, 15 Mar 2012 11:13:35 -0700 (PDT) Received: from dormouse.experts-exchange.com ([72.29.164.238]) by mx.google.com with ESMTPS id l8sm2368545pbd.62.2012.03.15.11.13.34 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 15 Mar 2012 11:13:34 -0700 (PDT) Sender: Jason Helfman Date: Thu, 15 Mar 2012 11:12:45 -0700 From: Jason Helfman To: Doug Barton Message-ID: <20120315181245.GB44984@dormouse.experts-exchange.com> References: <201203131629.q2DGTN9a082326@repoman.freebsd.org> <4F6171E0.4010506@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <4F6171E0.4010506@FreeBSD.org> X-Operating-System: FreeBSD 8.2-RELEASE amd64 Organization: The FreeBSD Project, http://www.freebsd.org X-Living-The-Dream: I love the SLO Life! X-PGP-FingerPrint: 8E0D C457 9A0F C91C 23F3 0454 2059 9A63 4150 D3DC X-PGP-Key: http://people.freebsd.org/~jgh/jgh.asc User-Agent: Mutt/1.5.21 (2010-09-15) X-Gm-Message-State: ALoCoQldxpEnmc5d/lG/siqsygJ6QlsBf/QZrxCML46xmRriLUT/okpyF4SLOm/6sujkx+ZBQtGi Cc: cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/www/resin3 Makefile distinfo pkg-plist ports/www/resin3/files install.sh patch-apache1-Makefile.in patch-apache2-Makefile.in patch-configure patch-resin.conf pkg-deinstall pkg-install pkg-message-advanced.in pkg-message.in ... X-BeenThere: cvs-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Mar 2012 18:13:36 -0000 On Wed, Mar 14, 2012 at 11:36:48PM -0500, Doug Barton thus spake: >At minimum this violates the rule about not adding new rc.d scripts with >the .sh suffix. Please carefully read >http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/rc-scripts.html, >especially the pre-commit checklist. (Hint, there are other problems >with these scripts. I suggest you read that web page and submit a patch >to -rc@ or -ports@) > >It's also not clear to me what the %%APP_NAME%% stuff in resin3 is for, >but I haven't looked at it deeply yet. I've submitted an update proposal over to freebsd-rc@ Thanks, Doug! -jgh -- Jason Helfman | FreeBSD Committer jgh@FreeBSD.org | http://people.freebsd.org/~jgh