From owner-svn-ports-all@freebsd.org Mon Mar 5 18:12:01 2018 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 6665AF44478; Mon, 5 Mar 2018 18:12:01 +0000 (UTC) (envelope-from yuri@freebsd.org) Received: from shell1.rawbw.com (shell1.rawbw.com [198.144.192.42]) by mx1.freebsd.org (Postfix) with ESMTP id F027B86DBF; Mon, 5 Mar 2018 18:12:00 +0000 (UTC) (envelope-from yuri@freebsd.org) Received: from yv.noip.me (c-24-4-131-132.hsd1.ca.comcast.net [24.4.131.132]) (authenticated bits=0) by shell1.rawbw.com (8.15.1/8.15.1) with ESMTPSA id w25IBrcl049599 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NO); Mon, 5 Mar 2018 10:11:54 -0800 (PST) (envelope-from yuri@freebsd.org) X-Authentication-Warning: shell1.rawbw.com: Host c-24-4-131-132.hsd1.ca.comcast.net [24.4.131.132] claimed to be yv.noip.me Reply-To: yuri@freebsd.org Subject: Re: svn commit: r463618 - head/sysutils/htop To: Sunpoet Po-Chuan Hsieh Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org References: <201803050507.w2557uXT016687@repo.freebsd.org> From: Yuri Message-ID: Date: Mon, 5 Mar 2018 10:11:52 -0800 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.25 X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Mar 2018 18:12:01 -0000 On 03/05/18 08:57, Sunpoet Po-Chuan Hsieh wrote: > > scripts/MakeHeader.py is no-op in fact. > It is used to generate header files but all header files are all ready > in the tarball. > I've run the script manually with python 3.6 and the generated header > files are identical with the ones from the tarball. > > USES=shebangfix is also unnecessary because scripts/MakeHeader.py is > unused. I saw this, and decided to keep USES=shebangfix. The reason was that MakeHeader.py file is only not run because all .h files are newer than .c files. If you will touch any .c file after extract, MakeHeader.py will be run. So it depends on timestamps, which is arbitrary and might change with the next release, making it error-prone. I asked them to fix this: https://github.com/hishamhm/htop/issues/754 > This port can be built without USES=localbase. For some reason, it fails for me without USES=localbase. It can't find ncurses.h Again, I asked them to fix it: https://github.com/hishamhm/htop/issues/755 Yuri