Date: Wed, 17 Nov 2004 19:50:31 GMT From: John Baldwin <jhb@FreeBSD.org> To: freebsd-usb@FreeBSD.org Subject: Re: kern/63837: [patch] USB: hid_is_collection() only looks for the first item Message-ID: <200411171950.iAHJoVNK059165@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR kern/63837; it has been noted by GNATS. From: John Baldwin <jhb@FreeBSD.org> To: nivit@email.it (Nicola Vitale) Cc: freebsd-gnats-submit@FreeBSD.org Subject: Re: kern/63837: [patch] USB: hid_is_collection() only looks for the first item Date: Wed, 17 Nov 2004 14:25:55 -0500 On Wednesday 17 November 2004 11:11 am, Nicola Vitale wrote: > Hello, > > > [John Baldwin, 2004-11-17T09:59:20-05::00] > > So, I think that the first part of the patch (setting h.report_ID to > > zero) is not needed. Basically, AFAICT, the effect of the patch is that > > hid_report_size() will now return the ID of the first device of a given > > kind rather than the last such device. > > I'm agree with you. But I can't understand how this patch to > hid_report_size() can magically eliminate the bug in hid_is_collection(), > which this PR originally referred to. > The function hid_is_collection() never calls hid_report_size() > directly or indirectly. I think it affects the IDs that other drivers use (see uhid.c for example) and thus they use a "more correct" ID. -- John Baldwin <jhb@FreeBSD.org> <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve" = http://www.FreeBSD.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200411171950.iAHJoVNK059165>