From owner-dev-commits-src-all@freebsd.org Tue Jan 26 22:50:50 2021 Return-Path: Delivered-To: dev-commits-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 9D2884E3982; Tue, 26 Jan 2021 22:50:50 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4DQMQf2Hq1z4bGV; Tue, 26 Jan 2021 22:50:49 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from tom.home (kib@localhost [127.0.0.1]) by kib.kiev.ua (8.16.1/8.16.1) with ESMTPS id 10QMoZQt024283 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Wed, 27 Jan 2021 00:50:38 +0200 (EET) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua 10QMoZQt024283 Received: (from kostik@localhost) by tom.home (8.16.1/8.16.1/Submit) id 10QMoZDG024282; Wed, 27 Jan 2021 00:50:35 +0200 (EET) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Wed, 27 Jan 2021 00:50:35 +0200 From: Konstantin Belousov To: Brooks Davis Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: d89c1c461ce3 - main - Reserve gaps in syscall numbers for local use Message-ID: References: <202101261828.10QISOKh066392@gitrepo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202101261828.10QISOKh066392@gitrepo.freebsd.org> X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FORGED_GMAIL_RCVD,FREEMAIL_FROM, NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on tom.home X-Rspamd-Queue-Id: 4DQMQf2Hq1z4bGV X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: dev-commits-src-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for all branches of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Jan 2021 22:50:50 -0000 On Tue, Jan 26, 2021 at 06:28:24PM +0000, Brooks Davis wrote: > The branch main has been updated by brooks: > > URL: https://cgit.FreeBSD.org/src/commit/?id=d89c1c461ce31bfc789dbb7bc5f4fce5824c595e > > commit d89c1c461ce31bfc789dbb7bc5f4fce5824c595e > Author: Brooks Davis > AuthorDate: 2021-01-26 18:27:45 +0000 > Commit: Brooks Davis > CommitDate: 2021-01-26 18:27:45 +0000 > > Reserve gaps in syscall numbers for local use > > It is best for auditing of syscalls.master if we only append to the > file. Reserving unimplemented system call numbers for local use makes > this policy and provides a large set of syscall numbers FreeBSD > derivatives can use without risk of conflict. > > Reviewed by: jhb, kevans, kib > Sponsored by: DARPA > Differential Revision: https://reviews.freebsd.org/D27988 > --- > sys/kern/init_sysent.c | 120 +++++++++++++++++++++++------------------------ > sys/kern/syscalls.c | 120 +++++++++++++++++++++++------------------------ > sys/kern/syscalls.master | 55 ++++++++++------------ > 3 files changed, 145 insertions(+), 150 deletions(-) I highly dislike this. You committed both manually edited file and generated files in one commit. Can we please avoid this? It is hard/impossible to read the diff as is.