From owner-freebsd-current@FreeBSD.ORG  Thu May 31 16:58:40 2007
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
X-Original-To: freebsd-current@freebsd.org
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id D07D516A421
	for <freebsd-current@freebsd.org>; Thu, 31 May 2007 16:58:40 +0000 (UTC)
	(envelope-from mux@freebsd.org)
Received: from elvis.mu.org (elvis.mu.org [192.203.228.196])
	by mx1.freebsd.org (Postfix) with ESMTP id C5EAF13C455
	for <freebsd-current@freebsd.org>; Thu, 31 May 2007 16:58:40 +0000 (UTC)
	(envelope-from mux@freebsd.org)
Received: by elvis.mu.org (Postfix, from userid 1920)
	id 99CB01A4D81; Thu, 31 May 2007 09:36:43 -0700 (PDT)
Date: Thu, 31 May 2007 18:36:43 +0200
From: Maxime Henrion <mux@FreeBSD.org>
To: Balwinder S Dheeman <bdheeman@hotmail.com>
Message-ID: <20070531163643.GU54713@elvis.mu.org>
References: <BAY128-F24CB2D178B39824911471FC32D0@phx.gbl>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <BAY128-F24CB2D178B39824911471FC32D0@phx.gbl>
User-Agent: Mutt/1.4.2.2i
Cc: freebsd-current@freebsd.org
Subject: Re: [PATCH] The current csup sources
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 31 May 2007 16:58:40 -0000

Balwinder S Dheeman wrote:
> Hi,
> 
> I think, the manpage /usr/src/contrib/csup/csup.1 is dated and, or have not 
> been updated per current csup sources.

I don't quite understand this statement.  Unless I have missed
something, the current csup manual page matches the code and thus
seems up-to-date to me.  You are talking about updating the manual
page but your config.c patch actually changes a few default settings
and modifies the manual page accordingly.

To pick one example, you are changing the default base directory
from /usr/local/etc/cvsup to /var/db.  This seems to indicate you
somehow confused the default FreeBSD settings with the default csup
settings.  It's true that we changed the default FreeBSD supfiles
to use /var/db instead of /usr for the default base directory, but
this has nothing to do with the default csup settings.

I see no reason to change the default csup settings; it would just
break the supfiles for people who use the default settings.  So,
it would be a POLA violation.  It would also break compatibility
with CVSup since it would still use the old defaults.

Cheers,
Maxime