From owner-cvs-all@FreeBSD.ORG  Tue Jul 29 00:44:21 2003
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 3268637B401; Tue, 29 Jul 2003 00:44:21 -0700 (PDT)
Received: from phk.freebsd.dk (phk.freebsd.dk [212.242.86.175])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 1973543F3F; Tue, 29 Jul 2003 00:44:20 -0700 (PDT)
	(envelope-from phk@phk.freebsd.dk)
Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.86.163])
	by phk.freebsd.dk (8.12.8/8.12.8) with ESMTP id h6T7iGV3061413;
	Tue, 29 Jul 2003 07:44:16 GMT
	(envelope-from phk@phk.freebsd.dk)
Received: from critter.freebsd.dk (localhost [127.0.0.1])
	by critter.freebsd.dk (8.12.9/8.12.9) with ESMTP id h6T7iF5H081628;
	Tue, 29 Jul 2003 09:44:15 +0200 (CEST)
	(envelope-from phk@phk.freebsd.dk)
To: Jeff Roberson <jroberson@chesapeake.net>
From: "Poul-Henning Kamp" <phk@phk.freebsd.dk>
In-Reply-To: Your message of "Tue, 29 Jul 2003 03:34:13 EDT."
             <20030729033236.X14210-100000@mail.chesapeake.net> 
Date: Tue, 29 Jul 2003 09:44:15 +0200
Message-ID: <81627.1059464655@critter.freebsd.dk>
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/kern vfs_syscalls.c 
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 29 Jul 2003 07:44:21 -0000

In message <20030729033236.X14210-100000@mail.chesapeake.net>, Jeff Roberson wr
ites:

>> >>   Log:
>> >>   Pass the file descriptor index down to vn_open.
>> >
>> >Why?  Was this discussed on arch?
>>
>> So that things like /dev/stream /dev/fd/* and similar can use a
>> less gruesome hack than today, and so that access to devices from
>> userland doesn't have to take the long tour through vnodes.
>>
>
>Yes, I see, but this is a pretty horrific layering violation.  I think we
>should think of the right way to do this instead of doing another gruesome
>hack.  I fear that this is going to snowball out.

I still think it looks a lot better than td_dupfd.

-- 
Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk@FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe    
Never attribute to malice what can adequately be explained by incompetence.