From owner-dev-commits-src-all@freebsd.org Tue Aug 17 15:51:35 2021 Return-Path: Delivered-To: dev-commits-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 7F6516667DF; Tue, 17 Aug 2021 15:51:35 +0000 (UTC) (envelope-from carpeddiem@gmail.com) Received: from mail-io1-f50.google.com (mail-io1-f50.google.com [209.85.166.50]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4GpwWC39pfz3GCw; Tue, 17 Aug 2021 15:51:35 +0000 (UTC) (envelope-from carpeddiem@gmail.com) Received: by mail-io1-f50.google.com with SMTP id e186so28272746iof.12; Tue, 17 Aug 2021 08:51:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=sKz+mtzsE77MSMOk+xYmAua9lzPLgVI0Wpg7qnUuhY0=; b=Ia+DxBo5cvmW4lPM7SpKaACRbyBHdwswVATSzVfKnZkXC6xB8aApa1yC8B/YnAc5Sf J2+HDi8ct8kR1SUBj0AgMszrO4J2AUBoKvP6POc891Sm3ttP9YqvVwJv9xKPSM6+FZtY JX8kpmjFSIHfjSf6m8+Hse2v48gfUNN3ja/DpYUXYU0SSwxlSmQl1/dLNE9Tfi7t9oCo hH2w7ZbInz6WCYv3mBUTKkan9mYIfdDzd6FK9FR4nuH8+ckV7IQ4DDpfYGLHHbH1P0TP j0/hdixhciBl1MVLTOwDS71tUFuHrC4uxAdBf6Hos3Nj/ZC3s+UhP8ukEV5tp+FZYRfe IPLg== X-Gm-Message-State: AOAM532G0PqsydFdY1dCdL730YOtZAOLQHGh4lzCMauapPg1WxOyEhjx fiIg5YS2840iqU7yfHgArNFUNUhmSfv0hzrRl3MZO32I+vg= X-Google-Smtp-Source: ABdhPJwwF80nCEUzDOYXT5XVEY9K0+HiVFSt/Oxhy6rf6shStkJ8qK9fEulSHU+9nssLA6qiJnblvkZE95T8g1SXFSk= X-Received: by 2002:a02:90d0:: with SMTP id c16mr3548873jag.106.1629215488476; Tue, 17 Aug 2021 08:51:28 -0700 (PDT) MIME-Version: 1.0 References: <202108170631.17H6VrAE094329@gitrepo.freebsd.org> In-Reply-To: <202108170631.17H6VrAE094329@gitrepo.freebsd.org> From: Ed Maste Date: Tue, 17 Aug 2021 11:51:12 -0400 Message-ID: Subject: Re: git: e8ad0a0059af - main - ipmi: New tunable to deactivate IPMI watchdog To: Wojciech Macek Cc: src-committers , "" , dev-commits-src-main@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 4GpwWC39pfz3GCw X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: dev-commits-src-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for all branches of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Aug 2021 15:51:35 -0000 On Tue, 17 Aug 2021 at 02:31, Wojciech Macek wrote: > > The branch main has been updated by wma: > > URL: https://cgit.FreeBSD.org/src/commit/?id=e8ad0a0059afe1cd0af39bab49018ae7bc9be937 > > commit e8ad0a0059afe1cd0af39bab49018ae7bc9be937 > Author: Wojciech Macek > AuthorDate: 2021-08-17 06:28:21 +0000 > Commit: Wojciech Macek > CommitDate: 2021-08-17 06:31:00 +0000 > > ipmi: New tunable to deactivate IPMI watchdog A bit of post-commit review: >From sysctl.9: "For boolean sysctls, negative logic should be totally avoided. That is, do not use names like no_foobar or foobar_disable. They are confusing and lead to configuration errors. Use positive logic instead: foobar, foobar_enable." So, preferable to have wd_init_enable = 1 instead. > +SYSCTL_INT(_hw_ipmi, OID_AUTO, wd_init_disable, CTLFLAG_RWTUN, > + &wd_init_disable, 0, ""); and we should have a description here.