From owner-freebsd-current@FreeBSD.ORG Fri Jun 4 07:30:56 2010 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 22EAA1065673 for ; Fri, 4 Jun 2010 07:30:56 +0000 (UTC) (envelope-from hselasky@c2i.net) Received: from swip.net (mailfe12.swipnet.se [212.247.155.97]) by mx1.freebsd.org (Postfix) with ESMTP id 7C3158FC26 for ; Fri, 4 Jun 2010 07:30:55 +0000 (UTC) X-Cloudmark-Score: 0.000000 [] X-Cloudmark-Analysis: v=1.0 c=1 a=BgaHaSUmPskA:10 a=0qYQvVkOOIcA:10 a=8nJEP1OIZ-IA:10 a=M8b_wTzEtboA:10 a=MnI1ikcADjEx7bvsp0jZvQ==:17 a=8kQB0OdkAAAA:8 a=JcFruBuwmrWImxcYfgoA:9 a=ztWxYv1U0Qc3yvh_wnkA:7 a=2EAs5ivF0utHJjvrfoOQV-lt7ggA:4 a=wPNLvfGTeEIA:10 a=9aOQ2cSd83gA:10 Received: from [188.126.201.140] (account mc467741@c2i.net HELO laptop002.hselasky.homeunix.org) by mailfe12.swip.net (CommuniGate Pro SMTP 5.2.19) with ESMTPA id 1196699316; Fri, 04 Jun 2010 09:30:53 +0200 From: Hans Petter Selasky To: "Marcelo/Porks" Date: Fri, 4 Jun 2010 09:28:09 +0200 User-Agent: KMail/1.12.4 (FreeBSD/8.0-STABLE; KDE/4.3.4; amd64; ; ) References: <201006031757.03341.hselasky@c2i.net> In-Reply-To: X-Face: +~\`s("[*|O,="7?X@L.elg*F"OA\I/3%^p8g?ab%RN'( =?iso-8859-1?q?=3B=5FIjlA=3A=0A=09hGE=2E=2EEw?=, =?iso-8859-1?q?XAQ*o=23=5C/M=7ESC=3DS1-f9=7BEzRfT=27=7CHhll5Q=5Dha5Bt-s=7Co?= =?iso-8859-1?q?TlKMusi=3A1e=5BwJl=7Dkd=7DGR=0A=09Z0adGx-x=5F0zGbZj=27e?=(Y[(UNle~)8CQWXW@:DX+9)_YlB[tIccCPN$7/L' MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201006040928.09768.hselasky@c2i.net> Cc: Garrett Cooper , freebsd-current@freebsd.org Subject: Re: Fwd: umodem (4) recognize a CDC-ACM device X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Jun 2010 07:30:56 -0000 On Friday 04 June 2010 03:02:52 Marcelo/Porks wrote: > On Thu, Jun 3, 2010 at 12:57 PM, Hans Petter Selasky wrote: > > On Thursday 03 June 2010 17:54:17 Hans Petter Selasky wrote: > >> On Thursday 03 June 2010 17:50:08 Hans Petter Selasky wrote: > >> > On Thursday 03 June 2010 16:22:33 Marcelo/Porks wrote: > >> > > On Wed, Jun 2, 2010 at 1:25 PM, Hans Petter Selasky > >> > > > >> > > >> > wrote: > >> > > > Hi, > >> > > > > >> > > > The problem is that LOW speed does not support BULK transfers > >> > > > according to the USB specification. I guess we could switch that > >> > > > support on, though I'd rather stick with the spec. > >> > > > > >> > > > Try changing this line in: > >> > > > > >> > > > src/sys/dev/usb/usb_transfer.c > > > > Hi, > > > > Should be like this: Note the structure is called "bulk_min": > > > > static const uint16_t bulk_min[USB_SPEED_MAX] = { > > [USB_SPEED_LOW] = 8, > > [USB_SPEED_FULL] = 8, > > [USB_SPEED_HIGH] = 512, > > [USB_SPEED_VARIABLE] = 512, > > [USB_SPEED_SUPER] = 1024, > > }; > > --HPS > > Hi, This was what I changed at first. I tried in a FreeBSD current > (Jun 3) and at 8.0-p3. > > At FreeBSD current I changed the line 3062. > > From: > [USB_SPEED_LOW] = 0, /* not supported */ > > To: > [USB_SPEED_LOW] = 8, > > > Like you suggested I'll try to talk with you in #bsdusb at efnet > > Thank you! Ok, I think you also need to remove the check for LOW speed in the EHCI/OHCI/UHCI controller drivers too. See usb/controller/{ehci.c,uhci.c,ohci.c} case UE_BULK: if (udev->speed != USB_SPEED_LOW) { ep->methods = &uhci_device_bulk_methods; } break; --HPS