From owner-cvs-src@FreeBSD.ORG Sat Aug 6 01:42:05 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0346316A41F; Sat, 6 Aug 2005 01:42:05 +0000 (GMT) (envelope-from ssouhlal@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id CA19043D46; Sat, 6 Aug 2005 01:42:04 +0000 (GMT) (envelope-from ssouhlal@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j761g4oe038762; Sat, 6 Aug 2005 01:42:04 GMT (envelope-from ssouhlal@repoman.freebsd.org) Received: (from ssouhlal@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j761g4WL038761; Sat, 6 Aug 2005 01:42:04 GMT (envelope-from ssouhlal) Message-Id: <200508060142.j761g4WL038761@repoman.freebsd.org> From: Suleiman Souhlal Date: Sat, 6 Aug 2005 01:42:04 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/kern vfs_subr.c src/sys/sys mount.h vnode.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 06 Aug 2005 01:42:05 -0000 ssouhlal 2005-08-06 01:42:04 UTC FreeBSD src repository Modified files: sys/kern vfs_subr.c sys/sys mount.h vnode.h Log: Holding a vnode doesn't prevent v_mount from disappearing (when the vnode is inactivated), possibly leading to a NULL dereference when checking if the mount wants knotes to be activated in the VOP hooks. So, we add a new vnode flag VV_NOKNOTE that is only set in getnewvnode(), if necessary, and check it when activating knotes. Since the flags are not erased when a vnode is being held, we can safely read them. Reviewed by: kris@ MFC after: 3 days Revision Changes Path 1.638 +2 -0 src/sys/kern/vfs_subr.c 1.198 +2 -4 src/sys/sys/mount.h 1.306 +1 -0 src/sys/sys/vnode.h