From owner-freebsd-threads@FreeBSD.ORG  Sat Feb 19 13:40:15 2005
Return-Path: <owner-freebsd-threads@FreeBSD.ORG>
Delivered-To: freebsd-threads@hub.freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 80DFD16A4D3
	for <freebsd-threads@hub.freebsd.org>;
	Sat, 19 Feb 2005 13:40:15 +0000 (GMT)
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 6206A43D48
	for <freebsd-threads@hub.freebsd.org>;
	Sat, 19 Feb 2005 13:40:15 +0000 (GMT)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	by freefall.freebsd.org (8.13.1/8.13.1) with ESMTP id j1JDeFNq003819
	for <freebsd-threads@freefall.freebsd.org>;
	Sat, 19 Feb 2005 13:40:15 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.13.1/8.13.1/Submit) id j1JDeFP4003818;
	Sat, 19 Feb 2005 13:40:15 GMT
	(envelope-from gnats)
Date: Sat, 19 Feb 2005 13:40:15 GMT
Message-Id: <200502191340.j1JDeFP4003818@freefall.freebsd.org>
To: freebsd-threads@FreeBSD.org
From: Robert Watson <rwatson@FreeBSD.org>
Subject: Re: threads/76938: include/unistd.h: ttyname_r prototype missing
X-BeenThere: freebsd-threads@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
Reply-To: Robert Watson <rwatson@FreeBSD.org>
List-Id: Threading on FreeBSD <freebsd-threads.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-threads>,
	<mailto:freebsd-threads-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-threads>
List-Post: <mailto:freebsd-threads@freebsd.org>
List-Help: <mailto:freebsd-threads-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-threads>,
	<mailto:freebsd-threads-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 19 Feb 2005 13:40:15 -0000

The following reply was made to PR threads/76938; it has been noted by GNATS.

From: Robert Watson <rwatson@FreeBSD.org>
To: Craig Rodrigues <rodrigc@crodrigues.org>
Cc: freebsd-gnats-submit@freebsd.org, tmclaugh@sdf.lonestar.org,
	freebsd-threads@freebsd.org
Subject: Re: threads/76938: include/unistd.h: ttyname_r prototype missing
Date: Sat, 19 Feb 2005 13:32:41 +0000 (GMT)

 On Fri, 18 Feb 2005, Craig Rodrigues wrote:
 
 > On Fri, Feb 18, 2005 at 03:51:01PM -0500, Daniel Eischen wrote:
 > > Style: all returns should be "return (foo)", not "return foo".
 > 
 > OK, the attached patch fixes this.
 > 
 > > This may also cause an ABI change since ttyname_r use to
 > > return (char *).  I'm not sure of the impact though 'cause
 > > it was never in a header file.
 > 
 > This does change the ABI, but I also don't know what the impact is,
 > since this function was not exported from a header file. 
 > 
 > The old ttyname_r() should have been declared static, since it was never
 > exported through a header file, but that's life.  At least the new
 > ttyname_r() conforms to SuS, so it has a better chance of working with
 > software written on other platforms. 
 
 You might want to ask Kris Kenneway if he could do a scan of the
 ports/packages to see what links against the ttyname_r symbol, if
 anything.
 
 Robert N M Watson