From owner-cvs-all Mon Jan 20 12:24:45 2003 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 104D537B401; Mon, 20 Jan 2003 12:24:44 -0800 (PST) Received: from elvis.mu.org (elvis.mu.org [192.203.228.196]) by mx1.FreeBSD.org (Postfix) with ESMTP id B986C43F18; Mon, 20 Jan 2003 12:24:43 -0800 (PST) (envelope-from bright@elvis.mu.org) Received: by elvis.mu.org (Postfix, from userid 1192) id 87E06AE313; Mon, 20 Jan 2003 12:24:38 -0800 (PST) Date: Mon, 20 Jan 2003 12:24:38 -0800 From: Alfred Perlstein To: phk@freebsd.org Cc: Matt Dillon , cvs-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/vm vm_swap.c Message-ID: <20030120202438.GB33821@elvis.mu.org> References: <200301202000.h0KK0WbW016017@repoman.freebsd.org> <4988.1043093176@critter.freebsd.dk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4988.1043093176@critter.freebsd.dk> User-Agent: Mutt/1.4i Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG * phk@freebsd.org [030120 12:06] wrote: > In message <200301202000.h0KK0WbW016017@repoman.freebsd.org>, Matt Dillon write > s: > >dillon 2003/01/20 12:00:32 PST > > > > Modified files: > > sys/vm vm_swap.c > > Log: > > Fix swapping to a file, it was broken when SPECSTRATEGY was introduced. > > Please don't spread FUD. > > This is clearly not the same word "broken" as I have learned in > school because the only sideeffect would be a single kernel printf > message on the console. > > But thanks for catching this. I probably should be paying more attention... but can you point me at a commit log or email explaining why the upper layers now have to query inside the vp to determine which VOP to call? -- -Alfred Perlstein [alfred@freebsd.org] 'Instead of asking why a piece of software is using "1970s technology," start asking why software is ignoring 30 years of accumulated wisdom.' To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message