From owner-svn-src-head@FreeBSD.ORG Mon Jan 12 08:25:11 2009 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7D0531065672; Mon, 12 Jan 2009 08:25:11 +0000 (UTC) (envelope-from obrien@NUXI.org) Received: from dragon.nuxi.org (trang.nuxi.org [74.95.12.85]) by mx1.freebsd.org (Postfix) with ESMTP id 435538FC13; Mon, 12 Jan 2009 08:25:11 +0000 (UTC) (envelope-from obrien@NUXI.org) Received: from dragon.nuxi.org (obrien@localhost [127.0.0.1]) by dragon.nuxi.org (8.14.2/8.14.2) with ESMTP id n0C8PA7A069299; Mon, 12 Jan 2009 00:25:10 -0800 (PST) (envelope-from obrien@dragon.nuxi.org) Received: (from obrien@localhost) by dragon.nuxi.org (8.14.2/8.14.2/Submit) id n0C8PA1a069298; Mon, 12 Jan 2009 00:25:10 -0800 (PST) (envelope-from obrien) Date: Mon, 12 Jan 2009 00:25:10 -0800 From: "David O'Brien" To: Christoph Mallon Message-ID: <20090112082510.GA69194@dragon.NUXI.org> References: <200812262254.mBQMsrbR052676@svn.freebsd.org> <4960FA9A.1090509@gmx.de> <20090111041543.GB17602@dragon.NUXI.org> <4969A626.6070908@gmx.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4969A626.6070908@gmx.de> X-Operating-System: FreeBSD 8.0-CURRENT User-Agent: Mutt/1.5.16 (2007-06-09) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r186504 - head/sbin/mount X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: obrien@freebsd.org List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Jan 2009 08:25:11 -0000 On Sun, Jan 11, 2009 at 08:56:22AM +0100, Christoph Mallon wrote: > David O'Brien schrieb: >> On Sun, Jan 04, 2009 at 07:06:18PM +0100, Christoph Mallon wrote: >>> I'm pretty sure $SUPERNATURAL_BEING_OF_YOUR_CHOICE killed a kitten for >>> the ugly hack you added to mount. The moment you overflow a buffer, you >>> are in no man's land and there's no escape. I appended a patch, which >>> solves this issue once and for all: The argv array gets dynamically >>> expanded, when its limit is reached. >>> Please - for all kittens out there - commit this patch. >> >> Hi Christoph, >> Unfortunately your patch doesn't work. >> For a 'ufs' file system listed in /etc/fstab >> $ umount /foo >> $ mount /foo >> Does not work. > > Why haven't you told me earlier? Wow, wish I did have the gift to know something before I know something. Especially tomorrow's lotto #'s. ;-) > It was a trivial glitch - just a missing > "--mnt_argc;". I would've corrected it right away. I tested with a CD and > this takes a different code path, which does not trigger the problem. > Attached is the corrected patch. Actually this version doesn't work either. Trying to mount root from ufs:/dev/ad4s1a .. usage: mount [-t fstype] [-o options] target_fs mount_point Mounting /etc/fstab filesystems failed, startup aborted ERROR: ABORTING BOOT (sending SIGTERM to parent)! Your over use of global variables made my adult cat cry in pain. Too bad you didn't at least follow the lead of what I committed. I've committed something in the spirit of your patches. I hope that suits everyone. -- -- David (obrien@FreeBSD.org) Q: Because it reverses the logical flow of conversation. A: Why is top-posting (putting a reply at the top of the message) frowned upon? Let's not play "Jeopardy-style quoting"