From owner-svn-src-head@FreeBSD.ORG  Wed Mar 11 09:46:42 2015
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id D14DE9E1;
 Wed, 11 Mar 2015 09:46:42 +0000 (UTC)
Received: from mail.turbocat.net (mail.turbocat.net
 [IPv6:2a01:4f8:d16:4514::2])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 904EBE22;
 Wed, 11 Mar 2015 09:46:42 +0000 (UTC)
Received: from laptop015.home.selasky.org
 (cm-176.74.213.204.customer.telag.net [176.74.213.204])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by mail.turbocat.net (Postfix) with ESMTPSA id E08571FE022;
 Wed, 11 Mar 2015 10:46:39 +0100 (CET)
Message-ID: <55000F2E.80804@selasky.org>
Date: Wed, 11 Mar 2015 10:47:26 +0100
From: Hans Petter Selasky <hps@selasky.org>
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64;
 rv:31.0) Gecko/20100101 Thunderbird/31.4.0
MIME-Version: 1.0
To: Ian Lepore <ian@FreeBSD.org>, src-committers@freebsd.org, 
 svn-src-all@freebsd.org, svn-src-head@freebsd.org, 
 Gleb Smirnoff <glebius@FreeBSD.org>
Subject: Re: svn commit: r279828 - head/sys/dev/cadence
References: <201503092239.t29MdxUo089384@svn.freebsd.org>
In-Reply-To: <201503092239.t29MdxUo089384@svn.freebsd.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 11 Mar 2015 09:46:42 -0000

On 03/09/15 23:39, Ian Lepore wrote:
> -		if ((ifp->if_flags & IFF_BROADCAST) == 0)
> +		if ((if_getflags(ifp) & IFF_BROADCAST) == 0)

A comment:

I think it would be better if the flags were not a bitmask, but an enum 
or structure, allowing for more than 32 or 64 bit-flags.

if (if_getflags(ifp, broadcast) == 0)

--HPS