From nobody Tue Feb 10 15:27:51 2026 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4f9QRq4hygz6RVbs for ; Tue, 10 Feb 2026 15:27:51 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4f9QRq225mz46f5 for ; Tue, 10 Feb 2026 15:27:51 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1770737271; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=HHt8grcBsCRn0TuA7dV3Pi3SF/EmwjqAOQRhBpDUzCM=; b=GVsbDGotGo5NTeaXaZr+3An2kHb9Vtt4uPb2r0Cr37OLXwQYtGsUxio5PxNeaJ/D0c2XlE vXwpg7VH/qwU8z7zLXTWv5wBTOE4ZKy6Hxc7SqRZ08fBJ4dSzTiFlzgscgi2xWH0JM9ARN IqyV5Uf+C/+l/p2jUDVavc71U4FtVeFnwqGek4rmflSCMa4b8WCpPR29x1IMD09d33hK8i smcQOMeCXV5abMR+Fk2puiUHVFao5IUwi0NO0+2uMi5W2CzxRfDen7TVl6GV+K9kYSi5y3 WpvXrJeOee5RYgk67S66wFmGZRr1DdVXcHg9mkALXXl5BYVIYPBZz9F2EXGgFQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1770737271; a=rsa-sha256; cv=none; b=VKDPsSG1CNyANoYaQJpnSoBVqs8Kgu7Wqhiup2ESI9pYp7l2jlh4xh0koUVM74sNADkvxP iQTRWZ1PgQnS4U2r6cVLYVfT+9tBi5LHUYDJGmKobQprfGhfJmzNn5ol/SBVGA6f8ur29Z Q54YzgeVAFPjFbl9pMt42/CYNXfkqi/8Wmkolb4ELOEnlwjyoiBX8Mi5JeP1qGrIBh/z7c aqOU7lVxMXRJjbQUYXmzfjBzvq2uVrSUARFLF4Uv7Oz0FsKqknY1xAoLxUZGGAAUV0Xt5v oQppUDxQMdWyLP8A8gAQt7SJ7KJDEWC3qXX+qfqjnRS2FpgdazXE1bBG/J7UfQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1770737271; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=HHt8grcBsCRn0TuA7dV3Pi3SF/EmwjqAOQRhBpDUzCM=; b=p47AStKwppDHr/up9bCZ7C4DXrnodFL+1i6oWkeb/PAnsQPnbOjjZctgUYdCjrp8dCiIm+ hXS6HhKMnYvaRNfC9kWwK7DJkmNI9c1yh9TtICaaT7aaM2RZfWCiPZJKOy5PykhfbIIYo+ 1507IN1QRAtNhg2c7bkWhEg331DvY16mlZVnwYDzwrmHxZv882I6yDQdviWBeo/kCye66Y PxIu2l5htif8Qz9ITTiyKab/XMjXqkCzd3KULJX5SzsEKJeZSY9wkSpvT6my3PdEAothTL okR9l/TJcWCwtibBDzo2iV91/VLSqre33iCXVhiBXz4gh5YT3Ibm74l0NU5uUQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4f9QRq1VJRz1NRR for ; Tue, 10 Feb 2026 15:27:51 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 45e66 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Tue, 10 Feb 2026 15:27:51 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Dag-Erling=?utf-8?Q? Sm=C3=B8rg?=rav Subject: git: 51c2384ce049 - stable/14 - diff: Add test case for pagination resource leak List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: des X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 51c2384ce049ec92e07901cf8a84c171e5d72104 Auto-Submitted: auto-generated Date: Tue, 10 Feb 2026 15:27:51 +0000 Message-Id: <698b4e77.45e66.2d1849a4@gitrepo.freebsd.org> The branch stable/14 has been updated by des: URL: https://cgit.FreeBSD.org/src/commit/?id=51c2384ce049ec92e07901cf8a84c171e5d72104 commit 51c2384ce049ec92e07901cf8a84c171e5d72104 Author: Dag-Erling Smørgrav AuthorDate: 2026-02-05 14:39:47 +0000 Commit: Dag-Erling Smørgrav CommitDate: 2026-02-10 14:24:19 +0000 diff: Add test case for pagination resource leak The pagination code leaks either processes or descriptors or both, depending on the exact version of the code you have. Add a test case which exercises this leak to facilitate fixing it. MFC after: 1 week Sponsored by: Klara, Inc. Reviewed by: thj, kevans Differential Revision: https://reviews.freebsd.org/D55111 (cherry picked from commit 270492602b9bd8b8fce4f021f055804978bf3f23) --- usr.bin/diff/tests/diff_test.sh | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+) diff --git a/usr.bin/diff/tests/diff_test.sh b/usr.bin/diff/tests/diff_test.sh index 453d82a4a3f3..2a07535d3d86 100755 --- a/usr.bin/diff/tests/diff_test.sh +++ b/usr.bin/diff/tests/diff_test.sh @@ -403,6 +403,27 @@ bigu_body() diff -U$(((1<<31)-2)) a b } +prleak_head() +{ + atf_set "descr" "Verify that pagination does not leak resources" +} +prleak_body() +{ + local n=32 + mkdir a b + for hi in $(jot -w%02x $n 0) ; do + mkdir a/$hi b/$hi + for lo in $(jot -w%02x $n 0) ; do + echo "$hi$lo" >a/$hi/$lo + echo "$hi$lo" >b/$hi/$lo + done + done + ulimit -n 1000 + ulimit -u 1000 + atf_check diff -rul a b + atf_check diff -Astone -rul a b +} + atf_init_test_cases() { atf_add_test_case simple @@ -432,4 +453,5 @@ atf_init_test_cases() atf_add_test_case dirloop atf_add_test_case bigc atf_add_test_case bigu + atf_add_test_case prleak }