From owner-cvs-src@FreeBSD.ORG Wed Jul 23 17:04:02 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id BAF8A37B401; Wed, 23 Jul 2003 17:04:02 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 57F9643FAF; Wed, 23 Jul 2003 17:04:02 -0700 (PDT) (envelope-from peter@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6O0420U050870; Wed, 23 Jul 2003 17:04:02 -0700 (PDT) (envelope-from peter@repoman.freebsd.org) Received: (from peter@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6O0424f050869; Wed, 23 Jul 2003 17:04:02 -0700 (PDT) Message-Id: <200307240004.h6O0424f050869@repoman.freebsd.org> From: Peter Wemm Date: Wed, 23 Jul 2003 17:04:02 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/contrib/tar/src tar.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Jul 2003 00:04:03 -0000 peter 2003/07/23 17:04:02 PDT FreeBSD src repository Modified files: contrib/tar/src tar.c Log: Fix an annoying bug in tar. When it converted 'tar zcf' to 'tar -z -c -f' it forgot to null terminate the new argv[] array. If you mixed this with $TAR_OPTIONS, phkmalloc and a whole bunch of other variables, you could end up with a segfault. This isn't strictly a phkmalloc victory since tar walks off the end of an array rather than use uninitialized malloc memory, but phkmalloc makes it easier to provoke. Revision Changes Path 1.3 +4 -1 src/contrib/tar/src/tar.c