From owner-svn-src-all@freebsd.org Tue Aug 2 00:25:10 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 4CA52BA264B; Tue, 2 Aug 2016 00:25:10 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: from mail-io0-f182.google.com (mail-io0-f182.google.com [209.85.223.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 0D833176F; Tue, 2 Aug 2016 00:25:09 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: by mail-io0-f182.google.com with SMTP id 38so198474621iol.0; Mon, 01 Aug 2016 17:25:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:reply-to:in-reply-to:references :from:date:message-id:subject:to:cc; bh=PzdlotRfPq/K2f+lKHWHcZtwTm8wn1oAGNqdIDoRoik=; b=aGLv4/TwZ94G4bQXC0ETJoCk5jpegGDt2h/tcUv28k6+2H4yz2NGrbcYKh+9Cwx9dY 3SdLjT9uc6W2qHmmYOi9Z7312pA8XYih7mmT3iaM4EtM8LYyz9g1E2DlcZPvr9plaOhx gMMmdjF4pYQ0oS4miixUiu3z3RSmY5Dx9A3VxIhDmcpkxJ64vGisxmNlb3k2hDk2Zg5t C4KgzQOZpJlFw7+LSlaWOkJU0SmTt4tFKaXHgkRDEXQ2p6dfS+w7wvkx6RJjPOMa5R7p W4IroV8avyQIYmoGLu1YhKeLmtqBDOkVR/CRQM7hgyPUXBQ0BameqFSZ9G/dkZ4dypFo wVIA== X-Gm-Message-State: AEkoouuTwdRZ01mbtq+xM2EVP5c1ku4K7WSOqqvMm4EqUaY1uwddw/D9LUuz9kWi/zDclA== X-Received: by 10.107.169.40 with SMTP id s40mr57552199ioe.19.1470097508591; Mon, 01 Aug 2016 17:25:08 -0700 (PDT) Received: from mail-it0-f42.google.com (mail-it0-f42.google.com. [209.85.214.42]) by smtp.gmail.com with ESMTPSA id b14sm161826itd.15.2016.08.01.17.25.08 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 01 Aug 2016 17:25:08 -0700 (PDT) Received: by mail-it0-f42.google.com with SMTP id j124so188533468ith.1; Mon, 01 Aug 2016 17:25:08 -0700 (PDT) X-Received: by 10.36.76.16 with SMTP id a16mr16137854itb.86.1470097507908; Mon, 01 Aug 2016 17:25:07 -0700 (PDT) MIME-Version: 1.0 Reply-To: cem@freebsd.org Received: by 10.36.233.67 with HTTP; Mon, 1 Aug 2016 17:25:07 -0700 (PDT) In-Reply-To: <20160801235852.GH7956@mutt-hardenedbsd> References: <201608012257.u71Mv3YA030076@repo.freebsd.org> <20160801235852.GH7956@mutt-hardenedbsd> From: Conrad Meyer Date: Mon, 1 Aug 2016 17:25:07 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r303650 - head/sys/opencrypto To: Shawn Webb Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org, "secteam@FreeBSD.org" , ecturt@gmail.com Content-Type: text/plain; charset=UTF-8 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Aug 2016 00:25:10 -0000 That would be difficult, as this is completely dead code in base. It could be accessed through the /dev/crypto device by a port, however. You haven't convinced me there is a security issue. Cheers, Conrad On Mon, Aug 1, 2016 at 4:58 PM, Shawn Webb wrote: > Adding CTurt to see if he wants to take a stab at writing a PoC exploit. > It'd be cool for an offensive researcher to determine if it's simply a > DoS. But regardless, a security fix is a security fix. All > currently-supported branches really should be updated. > > Thanks, > > Shawn > > On Mon, Aug 01, 2016 at 04:41:02PM -0700, Conrad Meyer wrote: >> Hey Shawn, >> >> I don't think this is security-related despite being a bug in >> crypto-adjacent code. At best it's a DoS, I think. >> >> Cheers, >> Conrad >> >> On Mon, Aug 1, 2016 at 4:15 PM, Shawn Webb wrote: >> > -----BEGIN PGP SIGNED MESSAGE----- >> > Hash: SHA512 >> > >> > >> > >> > On August 1, 2016 6:57:03 PM EDT, "Conrad E. Meyer" wrote: >> >>Author: cem >> >>Date: Mon Aug 1 22:57:03 2016 >> >>New Revision: 303650 >> >>URL: https://svnweb.freebsd.org/changeset/base/303650 >> >> >> >>Log: >> >> opencrypto AES-ICM: Fix heap corruption typo >> >> >> >>This error looks like it was a simple copy-paste typo in the original >> >>commit >> >> for this code (r275732). >> >> >> >> PR: 204009 >> >> Reported by: Chang-Hsien Tsai >> >> Sponsored by: EMC / Isilon Storage >> > >> > Since cem@ refuses to MFC even security fixes, can someone with a commit bit please MFC this within normal security-related MFC timeframe? Additionally, does a security advisory need to be sent out? CC'ing secteam@. >> > >> > Thanks, >> > >> > Shawn >> > >> > - -- >> > Sent from my Android device with K-9 Mail. Please excuse my brevity. >> > -----BEGIN PGP SIGNATURE----- >> > Version: APG v1.1.1 >> > >> > iQI/BAEBCgApBQJXn9ggIhxTaGF3biBXZWJiIDxzaGF3bkBzaGF3bndlYmIuaW5m >> > bz4ACgkQaoRlj1JFbu4Ypg//XLLOHX3y5ULHSEqEQ6tgUjQiR+9ADYKX1Zza3ghI >> > FsHEr7O8yi31jb8EJ9+oOiZOHxjAfLP+ezwNoa9xRUQu0IoTcCLU6PzCzHv2viaa >> > UZ+ae5xbB48i89o2ZshGTKgtwAzkCOhNkvPaAmS2yu14Xg+2CbhY2mCR+qdnAnMS >> > cUU4dTsqTI+cHQoE2ehzDst/ABSaBZa2XZKxFp3EeTb3r2bNAvh72zMv6ethU8Ht >> > 5VE7ZyRfQBpObZVcmSy6Sg8+vyjTRE4pdiajSqs3kIitPvxljwukMQ6DcdHCnJPx >> > IlOTXnM1wd7iHSwNTP8jniemOR4QrrQ3fEwglsnjp2t45ZnWi46LhfoekOinX42v >> > x7f+XWhcw0/oCF34q0rQ/YxFr0OcammmPMqjYKy7dlk2H6FSk9jnqh19lXu+qZP6 >> > UzlUS+IHHn7o0OaV9Tflsey7/24hFjEVAHFKZxsG7VzKaSjri6aJ8p2Mr2D1o1os >> > rEMF15pV2d9l7tIFN0FigqmffZswpTbk+uNNHc8rg+Tq7QV1fhceTgLLXRfqlpq8 >> > ES/Y3Epr22KCCEhftQw3fqC1XpOpn5CUc3svJx7llXWYc/c7RdxGDNSujFF3IARk >> > 741mx0N/ZkrcXZ/u/zk5+gMmS7NxhQXNk3QueRTIlqZv7e9GdlaYAPMZxQZKQKm3 >> > +YQ= >> > =B3c1 >> > -----END PGP SIGNATURE----- >> > >> > > > -- > Shawn Webb > Cofounder and Security Engineer > HardenedBSD > > GPG Key ID: 0x6A84658F52456EEE > GPG Key Fingerprint: 2ABA B6BD EF6A F486 BE89 3D9E 6A84 658F 5245 6EEE