From owner-freebsd-ports@FreeBSD.ORG  Fri Feb 11 00:01:30 2005
Return-Path: <owner-freebsd-ports@FreeBSD.ORG>
Delivered-To: freebsd-ports@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 56B4516A5AD
	for <ports@freebsd.org>; Fri, 11 Feb 2005 00:01:03 +0000 (GMT)
Received: from mail2out.barnet.com.au (mail2out.barnet.com.au [202.83.176.14])
	by mx1.FreeBSD.org (Postfix) with ESMTP id B3BE643D5D
	for <ports@freebsd.org>; Fri, 11 Feb 2005 00:00:43 +0000 (GMT)
	(envelope-from edwin@mavetju.org)
Received: by mail2out.barnet.com.au (Postfix, from userid 27)
	id 1B655707489; Fri, 11 Feb 2005 11:00:42 +1100 (EST)
X-Viruscan-Id: <420BF5A90000DF2D9EADAD@BarNet>
Received: from mail2-auth.barnet.com.au (mail2.barnet.com.au [202.83.176.13])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	Authority" (verified OK))
	by mail2.barnet.com.au (Postfix) with ESMTP id 485AD707481;
	Fri, 11 Feb 2005 11:00:41 +1100 (EST)
Received: from k7.mavetju (edwin-3.int.barnet.com.au [10.10.12.2])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	Certificate Authority" (verified OK))
	by mail2-auth.barnet.com.au (Postfix) with ESMTP id 82B6970747F;
	Fri, 11 Feb 2005 11:00:40 +1100 (EST)
Received: by k7.mavetju (Postfix, from userid 1001)
	id D61FD61BD; Fri, 11 Feb 2005 11:00:38 +1100 (EST)
Date: Fri, 11 Feb 2005 11:00:38 +1100
From: Edwin Groothuis <edwin@mavetju.org>
To: Ryan Sommers <ryans@gamersimpact.com>
Message-ID: <20050211000038.GA1175@k7.mavetju>
References: <53901.63.231.157.250.1107924833.squirrel@63.231.157.250>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <53901.63.231.157.250.1107924833.squirrel@63.231.157.250>
User-Agent: Mutt/1.5.6i
cc: ports@freebsd.org
Subject: Re: Twice included bsd.port.mk error
X-BeenThere: freebsd-ports@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Porting software to FreeBSD <freebsd-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports>
List-Post: <mailto:freebsd-ports@freebsd.org>
List-Help: <mailto:freebsd-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 11 Feb 2005 00:01:30 -0000

On Tue, Feb 08, 2005 at 09:53:53PM -0700, Ryan Sommers wrote:
> Line 895 bsd.port.mk:
> 
> .if defined(_PREMKINCLUDED)
> check-makefile::
>         @${ECHO_CMD} "${PKGNAME}: Makefile error: you cannot include
> bsd.port[.pre].mk twice"
>         @${FALSE}
> .endif
> 
> _PREMKINCLUDED= yes
> 
> attempts to catch including this file twice. However, it never does. (Try
> including it twice in a port.)

[~] edwin@k7>cat Makefile 
PORTVERSION=1
PORTNAME=boo
CATEGORIES=www

.include <bsd.port.pre.mk>
.include <bsd.port.pre.mk>
.include <bsd.port.post.mk>

[~] edwin@k7>make
boo-1: Makefile error: you cannot include bsd.port[.pre].mk twice

The issue is more that the port doesn't do anything unless
bsd.port.[post.]mk isn't included.

Edwin
-- 
Edwin Groothuis      |            Personal website: http://www.mavetju.org
edwin@mavetju.org    |          Weblog: http://weblog.barnet.com.au/edwin/