From owner-svn-src-head@freebsd.org  Wed Mar 16 20:36:02 2016
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 4B566AD37E1;
 Wed, 16 Mar 2016 20:36:02 +0000 (UTC)
 (envelope-from glebius@FreeBSD.org)
Received: from cell.glebi.us (glebi.us [96.95.210.25])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "cell.glebi.us", Issuer "cell.glebi.us" (not verified))
 by mx1.freebsd.org (Postfix) with ESMTPS id 376BF9D;
 Wed, 16 Mar 2016 20:36:01 +0000 (UTC)
 (envelope-from glebius@FreeBSD.org)
Received: from cell.glebi.us (localhost [127.0.0.1])
 by cell.glebi.us (8.15.2/8.15.2) with ESMTPS id u2GKa1O0077602
 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO);
 Wed, 16 Mar 2016 13:36:01 -0700 (PDT)
 (envelope-from glebius@FreeBSD.org)
Received: (from glebius@localhost)
 by cell.glebi.us (8.15.2/8.15.2/Submit) id u2GKa1jO077601;
 Wed, 16 Mar 2016 13:36:01 -0700 (PDT)
 (envelope-from glebius@FreeBSD.org)
X-Authentication-Warning: cell.glebi.us: glebius set sender to
 glebius@FreeBSD.org using -f
Date: Wed, 16 Mar 2016 13:36:01 -0700
From: Gleb Smirnoff <glebius@FreeBSD.org>
To: Hans Petter Selasky <hselasky@FreeBSD.org>
Cc: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Subject: Re: svn commit: r296933 - in head: share/man/man9 sys/sys
Message-ID: <20160316203601.GO1328@FreeBSD.org>
References: <201603160837.u2G8bqgr087126@repo.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201603160837.u2G8bqgr087126@repo.freebsd.org>
User-Agent: Mutt/1.5.24 (2015-08-30)
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.21
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 16 Mar 2016 20:36:02 -0000

On Wed, Mar 16, 2016 at 08:37:52AM +0000, Hans Petter Selasky wrote:
H> Modified: head/sys/sys/sysctl.h
H> ==============================================================================
H> --- head/sys/sys/sysctl.h	Wed Mar 16 06:42:15 2016	(r296932)
H> +++ head/sys/sys/sysctl.h	Wed Mar 16 08:37:52 2016	(r296933)
H> @@ -654,8 +654,10 @@ TAILQ_HEAD(sysctl_ctx_list, sysctl_ctx_e
H>  	SYSCTL_OID(parent, nbr, name,					\
H>  	    CTLTYPE_OPAQUE | CTLFLAG_MPSAFE | (access),			\
H>  	    (ptr), (len), sysctl_handle_counter_u64_array, "S", descr);	\
H> -	CTASSERT(((access) & CTLTYPE) == 0 ||				\
H> -	    ((access) & SYSCTL_CT_ASSERT_MASK) == CTLTYPE_OPAQUE)
H> +	CTASSERT((((access) & CTLTYPE) == 0 ||				\
H> +	    ((access) & SYSCTL_CT_ASSERT_MASK) == CTLTYPE_OPAQUE) &&	\
H> +	    sizeof(counter_u64_t) == sizeof(*(ptr)) &&			\
H> +	    sizeof(uint64_t) == sizeof(**(ptr)))

I don't agree with the last line. Does it assert that counter_u64_t is
implemented using uint64_t? That is true, but that is internal detail,
that might be changed in future.

-- 
Totus tuus, Glebius.