Date: Thu, 18 Jul 2013 03:52:45 GMT From: "r4721@tormail.org" <r4721@tormail.org> To: freebsd-gnats-submit@FreeBSD.org Subject: ports/180623: [patch] fix display issues in editors/chexedit Message-ID: <201307180352.r6I3qjsw079860@oldred.freebsd.org> Resent-Message-ID: <201307180400.r6I4009i040221@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 180623
>Category: ports
>Synopsis: [patch] fix display issues in editors/chexedit
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: change-request
>Submitter-Id: current-users
>Arrival-Date: Thu Jul 18 04:00:00 UTC 2013
>Closed-Date:
>Last-Modified:
>Originator: r4721@tormail.org
>Release:
>Organization:
>Environment:
>Description:
* remove patch hunk from patch-src-file.c that alters timestamp format. this was apparently to work around some issue in ncurses from freebsd 4 which is no longer present and today causes the timestamps to overflow their field in the directory view.
* add use_default_colors() call to patch-src-init.c to handle some changed default actions in ncurses over the years. this fixes the blank windows that occur with chexedit in some terminal programs like rxvt-unicode when background and foreground are set.
* add LICENSE
>How-To-Repeat:
>Fix:
Patch attached with submission follows:
Index: editors/chexedit/Makefile
===================================================================
--- editors/chexedit/Makefile (revision 323155)
+++ editors/chexedit/Makefile (working copy)
@@ -12,6 +12,9 @@
MAINTAINER= amdmi3@FreeBSD.org
COMMENT= Full screen text mode Hex editor using the [n]curses library
+LICENSE= GPLv2
+LICENSE_FILE= ${WRKSRC}/COPYING
+
GNU_CONFIGURE= yes
PLIST_FILES= bin/chexedit
Index: editors/chexedit/files/patch-src-file.c
===================================================================
--- editors/chexedit/files/patch-src-file.c (revision 323155)
+++ editors/chexedit/files/patch-src-file.c (working copy)
@@ -8,14 +8,3 @@
#include <grp.h>
#include <pwd.h>
-@@ -618,8 +619,8 @@
-
- wprintw (Globals.wmain,
- /* why does it seem like on OpenBSD this is broken? */
--#if defined(__OpenBSD__) || defined(BROKEN)
-- "%s %-8s %-8s %10ld %1d\b2d-%02d-%02d %02d:%02d ",
-+#if defined(__OpenBSD__) || defined(__FreeBSD__) || defined(BROKEN)
-+ "%s %-8s %-8s %10ld %1d\b%04d-%02d-%02d %02d:%02d ",
- #else
- "%s %-8s %-8s %10ld %d-%02d-%02d %02d:%02d ",
- #endif
Index: editors/chexedit/files/patch-src-init.c
===================================================================
--- editors/chexedit/files/patch-src-init.c (revision 323155)
+++ editors/chexedit/files/patch-src-init.c (working copy)
@@ -12,7 +12,15 @@
extern char **environ;
-@@ -463,7 +468,7 @@
+@@ -250,6 +255,7 @@
+ if (color_term != -1)
+ {
+ start_color ();
++ use_default_colors();
+ if ((color_term = has_colors ()))
+ {
+ color_term = 1;
+@@ -463,7 +469,7 @@
filestat.st_size = DEFAULT_BUFFER_SIZE;
}
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201307180352.r6I3qjsw079860>