From owner-cvs-ports@FreeBSD.ORG Thu Dec 15 13:00:33 2011 Return-Path: Delivered-To: cvs-ports@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id CC717106566B; Thu, 15 Dec 2011 13:00:33 +0000 (UTC) (envelope-from jbeich@tormail.net) Received: from server2.hudsonvalleyhost.com (server2.hudsonvalleyhost.com [66.7.195.77]) by mx1.freebsd.org (Postfix) with ESMTP id 74CEF8FC12; Thu, 15 Dec 2011 13:00:32 +0000 (UTC) Received: from rainbowwarrior.torservers.net ([77.247.181.164]:20936 helo=internal.tormail.net) by server2.hudsonvalleyhost.com with esmtpsa (TLSv1:RC4-SHA:128) (Exim 4.69) (envelope-from ) id 1RbAv7-0021qc-4Y; Thu, 15 Dec 2011 08:00:23 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tormail.net; s=tm; h=Message-Id:X-TorMail-User:Content-Type:MIME-Version:References:Date:In-Reply-To:Subject:Cc:To:From; bh=wIZ0wFZ/h0g2dTVs9cqM9DpTejQtQoKjjWvbfeSengQ=; b=F5IBqCWDgpM3pho8G9wubTmWDU90yD+fyBHoYL06rOeAeZz0Rd7zpKosKDPjsuwKDCrAJJuRXwDYnIud5kxDdgYFaOupL/dTz4AKuqO8QoPgynuER7Ywxxu4isBk8LOFO8jOhRn2OZimtFknU8/L9nASWazGmHZdBJxxGNUedDU=; Received: from jbeich by internal.tormail.net with local (Exim 4.63) (envelope-from ) id 1RbAuc-000Mkz-3U; Thu, 15 Dec 2011 12:59:52 +0000 From: Jan Beich To: Alexey Dokuchaev In-Reply-To: <201112151145.pBFBjABj033318@repoman.freebsd.org> (Alexey Dokuchaev's message of "Thu, 15 Dec 2011 11:45:10 +0000 (UTC)") Date: Thu, 15 Dec 2011 17:57:15 +0500 References: <201112151145.pBFBjABj033318@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain X-TorMail-User: jbeich Message-Id: <1RbAuc-000Mkz-3U@internal.tormail.net> X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - server2.hudsonvalleyhost.com X-AntiAbuse: Original Domain - freebsd.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tormail.net X-Source: X-Source-Args: X-Source-Dir: Cc: cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/graphics/lensfun Makefile pkg-plist X-BeenThere: cvs-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Dec 2011 13:00:33 -0000 Alexey Dokuchaev writes: > FreeBSD ports repository > > Modified files: > graphics/lensfun Makefile pkg-plist > Log: > - Change license: GPL only applies to binaries, which are not installed by > the port, so use more appropriate LGPL; this also brings us in line with > most of the GNU/Linux distributions > - Remove licenses and useless documentation (README file containing build > instructions); 95% of users do not interact with lensfun directly anyway > - Adjust Python dependency: it is only required during build time > - Enable verbose build (helps to study logs) > - Respect CXX/AR[*], CFLAGS; adjust COMMENT and Makefile header Why not fix WITH_DEBUG by removing `-s' from GCC.LDFLAGS.release? pmcstat/dtrace also want unstripped binaries, e.g. set via empty STRIP in make.conf. --- graphics/lensfun/Makefile +++ graphics/lensfun/Makefile @@ -33,17 +33,23 @@ PLIST_SUB+= LIBVERSION=${LIBVERSION} +.include + +.if defined(STRIP) && ${STRIP} != "" +LDFLAGS+= -s +.endif + post-patch: .SILENT ${REINPLACE_CMD} -e '1s|#!/usr/bin/python|#!/usr/bin/env python|' \ -e 's|make --version|g&|' -e '/DOXYGEN/d' ${WRKSRC}/configure ${REINPLACE_CMD} -e \ 's|CONF_LIBDIR)pkgconfig|CONF_LIBDIR)../libdata/pkgconfig|' \ ${WRKSRC}/build/tibs/compiler/pkgconfig.mak - ${REINPLACE_CMD} -e '/-s -O3/d' ${WRKSRC}/build/tibs/compiler/gcc.mak + ${REINPLACE_CMD} -e '/-s/d' ${WRKSRC}/build/tibs/compiler/gcc.mak ${REINPLACE_CMD} -e '/GROUPS/s| DOCS||' ${WRKSRC}/build/tibs/rules.mak post-install: ${LN} -sf lib${PORTNAME}.so \ ${PREFIX}/lib/lib${PORTNAME}.so.${LIBVERSION} -.include +.include