From owner-cvs-src@FreeBSD.ORG Thu Dec 6 19:04:17 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 213F116A468 for ; Thu, 6 Dec 2007 19:04:17 +0000 (UTC) (envelope-from kip.macy@gmail.com) Received: from ro-out-1112.google.com (ro-out-1112.google.com [72.14.202.177]) by mx1.freebsd.org (Postfix) with ESMTP id C035213C46E for ; Thu, 6 Dec 2007 19:04:16 +0000 (UTC) (envelope-from kip.macy@gmail.com) Received: by ro-out-1112.google.com with SMTP id k5so6679760rog for ; Thu, 06 Dec 2007 11:04:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; bh=ePiIQzrpwY8VORpUqmyxl2JVBEqmJz4fHGNF0Q1FLZM=; b=jfilOaUwBFVdGXqxfob157w9vu1C3mSkHj4xuw9zt2QycOAEi0tLit3p9FfBrGDbtq570sRPLYvW38weD8CReRnLmyHpL9SPbOcM+aSpgCHY5pn32JuP9S751E2+F1EWZp/8dx6f5YzNhMKWf8EYAUOZ4USxOripZ9TUNLnWDKU= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=UbsH+JAMLXcz1dMrTVCdiU3Co2aBBsYis8e/kf/SKiNlhqyoMQ6d1XS1k3OErc16vx4TGguXqydPR8YiijxqWmt6CeUXo66Buc4jVcLAXbWrc0X/3JydozOL1n4hornLFE0uKG4Z7PnGuI/sY8LtKY04TTszv6pwSICAjf269PE= Received: by 10.114.81.1 with SMTP id e1mr1530599wab.1196967854453; Thu, 06 Dec 2007 11:04:14 -0800 (PST) Received: by 10.114.13.15 with HTTP; Thu, 6 Dec 2007 11:04:14 -0800 (PST) Message-ID: Date: Thu, 6 Dec 2007 11:04:14 -0800 From: "Kip Macy" To: "Bruce Evans" In-Reply-To: <20071206202639.N11122@delplex.bde.org> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <200712060400.lB640xxi025146@repoman.freebsd.org> <20071206202639.N11122@delplex.bde.org> Cc: cvs-src@freebsd.org, src-committers@freebsd.org, Kip Macy , cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/sys param.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 06 Dec 2007 19:04:17 -0000 On Dec 6, 2007 2:25 AM, Bruce Evans wrote: > > On Thu, 6 Dec 2007, Kip Macy wrote: > > > kmacy 2007-12-06 04:00:59 UTC > > > > FreeBSD src repository > > > > Modified files: > > sys/sys param.h > > Log: > > Respect the fact that the value a may be constant so cast to const uint8_t * > > > > Revision Changes Path > > 1.318 +2 -2 src/sys/sys/param.h > > The correct fix is to back out 1.317. If not, at least spell `unsigned > char' correctly and fix the other new style bug (a line longer than > 80 characters from adding `const'). Using uint8_t is only a style bug > since POSIX probably requires unsigned char to be the same as uint8_t. > If unsigned char is larger than uint8_t, then revs.1.317-318 give > undefined behaviour (aliasing bugs) and clearly broken behaviour (wrong > divisor NBBY). These bugs are easy to avoid by using the correct > spelling. > I'm inclined to do whatever you say so long as my code works without a substantial rewrite. However, can you please point me at where it says uint8_t is not style(9) compliant? Thanks. -Kip