From owner-cvs-src@FreeBSD.ORG Wed Feb 1 00:25:26 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E033616A420; Wed, 1 Feb 2006 00:25:26 +0000 (GMT) (envelope-from jeff@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id A4FF843D69; Wed, 1 Feb 2006 00:25:26 +0000 (GMT) (envelope-from jeff@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id k110PQP5092512; Wed, 1 Feb 2006 00:25:26 GMT (envelope-from jeff@repoman.freebsd.org) Received: (from jeff@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id k110PQ6Z092511; Wed, 1 Feb 2006 00:25:26 GMT (envelope-from jeff) Message-Id: <200602010025.k110PQ6Z092511@repoman.freebsd.org> From: Jeff Roberson Date: Wed, 1 Feb 2006 00:25:26 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/coda coda_vnops.c src/sys/fs/msdosfs msdosfs_vnops.c src/sys/kern vfs_syscalls.c src/sys/nfsserver nfs_serv.c nfs_srvsubs.c src/sys/ufs/ufs ufs_extattr.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Feb 2006 00:25:27 -0000 jeff 2006-02-01 00:25:26 UTC FreeBSD src repository Modified files: sys/coda coda_vnops.c sys/fs/msdosfs msdosfs_vnops.c sys/kern vfs_syscalls.c sys/nfsserver nfs_serv.c nfs_srvsubs.c sys/ufs/ufs ufs_extattr.c Log: - Reorder calls to vrele() after calls to vput() when the vrele is a directory. vrele() may lock the passed vnode, which in these cases would give an invalid lock order of child -> parent. These situations are deadlock prone although do not typically deadlock because the vrele is typically not releasing the last reference to the vnode. Users of vrele must consider it as a call to vn_lock() and order it appropriately. MFC After: 1 week Sponsored by: Isilon Systems, Inc. Tested by: kkenn Revision Changes Path 1.68 +9 -12 src/sys/coda/coda_vnops.c 1.163 +2 -2 src/sys/fs/msdosfs/msdosfs_vnops.c 1.401 +11 -11 src/sys/kern/vfs_syscalls.c 1.162 +37 -38 src/sys/nfsserver/nfs_serv.c 1.138 +1 -1 src/sys/nfsserver/nfs_srvsubs.c 1.84 +1 -1 src/sys/ufs/ufs/ufs_extattr.c