From owner-freebsd-net@FreeBSD.ORG Tue Feb 14 14:58:13 2012 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 9CB4B106566C for ; Tue, 14 Feb 2012 14:58:13 +0000 (UTC) (envelope-from mjr@cs.wisc.edu) Received: from sabe.cs.wisc.edu (sabe.cs.wisc.edu [128.105.6.20]) by mx1.freebsd.org (Postfix) with ESMTP id 664188FC13 for ; Tue, 14 Feb 2012 14:58:13 +0000 (UTC) Received: from Core (71-90-102-157.dhcp.ftbg.wi.charter.com [71.90.102.157]) (authenticated bits=0) by sabe.cs.wisc.edu (8.14.1/8.14.1) with ESMTP id q1EEwBUl018040 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO); Tue, 14 Feb 2012 08:58:11 -0600 From: "Matt Renzelmann" To: References: <003101cce1b8$fe7def80$fb79ce80$@cs.wisc.edu> <20120215024445.GA1340@michelle.cdnetworks.com> In-Reply-To: <20120215024445.GA1340@michelle.cdnetworks.com> Date: Tue, 14 Feb 2012 08:58:03 -0600 Message-ID: <003b01cceb29$116722a0$343567e0$@cs.wisc.edu> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Outlook 14.0 Thread-Index: AQJev1HuoMGB37k2LEBCZmK2l7Ba2wLJHbSglQKJ4tA= Content-Language: en-us Cc: freebsd-net@freebsd.org Subject: RE: 8139 driver question X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Feb 2012 14:58:13 -0000 You're welcome. For what it's worth, the Linux driver uses the second set of values referenced below. I think one of the two drivers likely has a bug, but I'm not currently in a position to test it on hardware, so you don't need to fix it on my account :) Thanks and regards, Matt -----Original Message----- From: YongHyeon PYUN [mailto:pyunyh@gmail.com] Sent: Tuesday, February 14, 2012 8:45 PM To: Matt Renzelmann Cc: freebsd-net@freebsd.org Subject: Re: 8139 driver question On Thu, Feb 02, 2012 at 08:43:09AM -0600, Matt Renzelmann wrote: > Hello, > > This will seem a bit off the wall, but I just noticed a discrepancy between the > registers defined in the pci/if_rlreg.h directory and those specified on the > RealTek datasheets for the antique RealTek 8139. > > In particular, as defined in the header, the registers in question are: > #define RL_CFG0 0x0051 /* config register #0 */ > #define RL_CFG1 0x0052 /* config register #1 */ > #define RL_CFG2 0x0053 /* config register #2 */ > #define RL_CFG3 0x0054 /* config register #3 */ > #define RL_CFG4 0x0055 /* config register #4 */ > #define RL_CFG5 0x0056 /* config register #5 */ > > The RealTek data sheets for the 8139, however, all indicate that these should be > set to something like this: > #define RL_CFG0 0x0051 /* config register #0 */ > #define RL_CFG1 0x0052 /* config register #1 */ > // No Config2 > #define RL_CFG3 0x0059 /* config register #3 */ > #define RL_CFG4 0x005A /* config register #4 */ > #define RL_CFG5 0x00D8 /* config register #5 */ > > The datasheets I'm referencing are available here: > http://realtek.info/pdf/ > > Specifically: > http://realtek.info/pdf/rtl8139d.pdf > http://realtek.info/pdf/rtl8139cp.pdf > > I believe the registers currently used apply to the 8169, but not necessarily > the 8139 family -- can someone, hopefully easily, verify that the 8139 driver is > using the right registers? The 8139 series may need the slightly different > values used above to enable functionality like wake-on-lan. > Thanks for letting me know that. As you said RTL8139/RTL8139C+ use different config registers and it may affect WOL functionality. When I implemented WOL on rl(4), I remember WOL worked at that time. After reading your mail, I wonder how it would have worked at that time. :-( Thanks. > Thanks and regards, > Matt