From owner-freebsd-current@FreeBSD.ORG  Wed Apr 13 03:28:44 2005
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id E1DDE16A4CE
	for <current@freebsd.org>; Wed, 13 Apr 2005 03:28:44 +0000 (GMT)
Received: from rproxy.gmail.com (rproxy.gmail.com [64.233.170.202])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 7AD7643D1D
	for <current@freebsd.org>; Wed, 13 Apr 2005 03:28:44 +0000 (GMT)
	(envelope-from kabaev@gmail.com)
Received: by rproxy.gmail.com with SMTP id j1so36035rnf
        for <current@freebsd.org>; Tue, 12 Apr 2005 20:28:44 -0700 (PDT)
DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
	s=beta; d=gmail.com;
	h=received:date:from:to:subject:message-id:in-reply-to:references:x-mailer:mime-version:content-type:content-transfer-encoding;
	b=VSBFm7mXqF2fjYs8DRcv5Gd9EEjw0D+ddGd54XcMf7RybTT2dUSCApOT5OGaMgzYNTZF39dFksq2OV52ZAuf4aL7He7gaV33d/7JruyEJV08YrQW2pqBKu+ugfdVVSkAGlGDRU4aEAaKKpBMc6q8J8YE+ZjidPqSKwxXjUgB1aM=
Received: by 10.38.82.20 with SMTP id f20mr172068rnb;
        Tue, 12 Apr 2005 20:28:44 -0700 (PDT)
Received: from kan.dnsalias.net ([151.203.236.228])
        by mx.gmail.com with ESMTP id 3sm3375rnr.2005.04.12.20.28.43;
        Tue, 12 Apr 2005 20:28:44 -0700 (PDT)
Date: Tue, 12 Apr 2005 23:28:41 -0400
From: Alexander Kabaev <kabaev@gmail.com>
To: current@FreeBSD.org
Message-ID: <20050412232841.230467c2@kan.dnsalias.net>
In-Reply-To: <0842a01b5aa0cfcd84763fff4a30113e@FreeBSD.org>
References: <0842a01b5aa0cfcd84763fff4a30113e@FreeBSD.org>
X-Mailer: Sylpheed-Claws 1.0.4 (GTK+ 1.2.10; i386-portbld-freebsd6.0)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
X-Mailman-Approved-At: Wed, 13 Apr 2005 15:55:49 +0000
Subject: Re: [PATCH] Allow watching of vnodes that reside on non-UFS
 filesystems	with kqueue
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 13 Apr 2005 03:28:45 -0000

On Tue, 12 Apr 2005 23:05:45 -0400
Suleiman Souhlal <ssouhlal@FreeBSD.org> wrote:

> Hello,
> 
> The patch at 
> http://people.freebsd.org/~ssouhlal/testing/kqueue-hooks-20050412.diff
> 
> allows watching vnodes on non-UFS filesystems with kqueue.
> 
> It moves the VN_KNOTE calls to pre and post VOP_* hooks. These hooks 
> are currently used for VFS lock debugging only, but I made them 
> unconditional. I think that they we could eventually move the 
> mac_check_vnode_* calls into them too, with a bit of work.
> 
> I would like to commit this to HEAD, if there are no objections.

I for one am not thrilled by all the hooks being made unconditional and 
being inserted right into the middle of critical path for the benefit of
rarely used feature.
-- 
Alexander Kabaev