From owner-freebsd-bugs@FreeBSD.ORG Mon Nov 12 13:30:01 2007 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 45D6216A419 for ; Mon, 12 Nov 2007 13:30:01 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 24D2A13C49D for ; Mon, 12 Nov 2007 13:30:01 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.1/8.14.1) with ESMTP id lACDU1A5099837 for ; Mon, 12 Nov 2007 13:30:01 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.1/8.14.1/Submit) id lACDU0h3099836; Mon, 12 Nov 2007 13:30:00 GMT (envelope-from gnats) Resent-Date: Mon, 12 Nov 2007 13:30:00 GMT Resent-Message-Id: <200711121330.lACDU0h3099836@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Lev Levinson Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 476B816A468 for ; Mon, 12 Nov 2007 13:29:01 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21]) by mx1.freebsd.org (Postfix) with ESMTP id E0B8813C4C1 for ; Mon, 12 Nov 2007 13:29:00 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.14.1/8.14.1) with ESMTP id lACDSYui063308 for ; Mon, 12 Nov 2007 13:28:34 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.14.1/8.14.1/Submit) id lACDSYDE063306; Mon, 12 Nov 2007 13:28:34 GMT (envelope-from nobody) Message-Id: <200711121328.lACDSYDE063306@www.freebsd.org> Date: Mon, 12 Nov 2007 13:28:34 GMT From: Lev Levinson To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: misc/118001: sysinstall can't read some packages from INDEX. (buffer overflow). X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Nov 2007 13:30:01 -0000 >Number: 118001 >Category: misc >Synopsis: sysinstall can't read some packages from INDEX. (buffer overflow). >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Mon Nov 12 13:30:00 UTC 2007 >Closed-Date: >Last-Modified: >Originator: Lev Levinson >Release: FreeBSD-7.0-BETA1 >Organization: >Environment: FreeBSD porky.dep24 7.0-BETA1 FreeBSD 7.0-BETA1 #0: Wed Nov 7 13:45:40 MSK 2007 root@porky.dep24:/usr/src/sys/i386/compile/GENERIC_NODEBUG i386 >Description: Sysinstall reads not-used fields of INDEX-file (especially "build dependencies") into buffer: char junk[2048] (see: src/usr.sbin/sysinstall/index.c:294,310) But to-day big packages (like kde) has more then 2048 chars in that field. As a result, buffer junk[] overflows and garbage appears in Packages menu of sysinstall. >How-To-Repeat: cd /usr/ports make fetchindex mkdir -p /tmp/tttt/packages egrep "^kde" INDEX-7 > /tmp/tttt/packages/INDEX sysinstall In it menu select: Configure --> Packages --> File System --> enter path: "/tmp/tttt" look at garbage in menu "Package Selection". >Fix: Increase size of buffer junk[] at src/usr.sbin/sysinstall/index.c:294 from 2048 to 4096 (or 8192). >Release-Note: >Audit-Trail: >Unformatted: