From owner-freebsd-ports@FreeBSD.ORG Tue Sep 10 16:07:53 2013 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 0EA54718 for ; Tue, 10 Sep 2013 16:07:53 +0000 (UTC) (envelope-from jhein@symmetricom.com) Received: from duck.symmetricom.us (duck.symmetricom.us [206.168.13.214]) by mx1.freebsd.org (Postfix) with ESMTP id D510A26A6 for ; Tue, 10 Sep 2013 16:07:52 +0000 (UTC) Received: from gromit.timing.com (gromit.timing.com [206.168.13.209]) by duck.symmetricom.us (8.14.6/8.14.6) with ESMTP id r8AG7qYH094182; Tue, 10 Sep 2013 10:07:52 -0600 (MDT) (envelope-from jhein@symmetricom.com) Received: from gromit.timing.com (localhost [127.0.0.1]) by gromit.timing.com (8.14.7/8.14.5) with ESMTP id r8AG7XcH000917; Tue, 10 Sep 2013 10:07:33 -0600 (MDT) (envelope-from jhein@gromit.timing.com) Received: (from jhein@localhost) by gromit.timing.com (8.14.7/8.14.6/Submit) id r8AG7X76000916; Tue, 10 Sep 2013 10:07:33 -0600 (MDT) (envelope-from jhein) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <21039.17348.897687.242628@gromit.timing.com> Date: Tue, 10 Sep 2013 10:07:32 -0600 From: John Hein To: "O. Hartmann" Subject: Re: HELP! nvidia-driver patch: Weird REPLACE_CMD and command-line-sed behaviour. HELP! In-Reply-To: <20130910175544.3feb9029@thor.walstatt.dyndns.org> References: <20130910015144.41c88d52@thor.walstatt.dyndns.org> <21039.10674.968260.7845@gromit.timing.com> <20130910162616.6ce1d52f@thor.walstatt.dyndns.org> <21039.16301.572328.142329@gromit.timing.com> <20130910175544.3feb9029@thor.walstatt.dyndns.org> X-Mailer: VM 8.2.0b-trunk-1484 under 24.3.1 (i386-portbld-freebsd8.3) Cc: FreeBSD Ports X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Sep 2013 16:07:53 -0000 O. Hartmann wrote at 17:55 +0200 on Sep 10, 2013: > On Tue, 10 Sep 2013 09:50:05 -0600 > John Hein wrote: > > Actually I should have said you want: > > > > .if ${OSVERSION} > 1000055 > > > > The API change to vm_map_find was made between shortly before 1000055. > > > I'm on FreeBSD 10.0-CURRENT #1 r255434: Tue Sep 10 02:01:02 CEST 2013 > amd64 and when calling > > make -VOSVERSION in x11/nvidia-driver I receive > > 1000054 You are in an unfortunate window between the moment the API change was committed (255426) and the OSVERSION was bumped (255449). That shouldn't happen ideally, but sometimes it does. The "backward" gap from 255426 to the last bump (255321) is larger than the "forward" gap, and in absence of better guidance, you should generally pick the OSVERSION larger than a particular API change to key off. Your false 1000054 is really 1000055 in spirit, but human committers just didn't catch on until a bit later. So you have to pick the lesser of two evils - which I am claiming is 1000055.