From owner-cvs-all@FreeBSD.ORG Tue Sep 12 11:01:07 2006 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 83EDC16A4F1; Tue, 12 Sep 2006 11:01:07 +0000 (UTC) (envelope-from itetcu@people.tecnik93.com) Received: from it.buh.tecnik93.com (it.buh.tecnik93.com [81.196.204.98]) by mx1.FreeBSD.org (Postfix) with ESMTP id 14C4343D4C; Tue, 12 Sep 2006 11:01:07 +0000 (GMT) (envelope-from itetcu@people.tecnik93.com) Received: from it.buh.tecnik93.com (localhost [127.0.0.1]) by it.buh.tecnik93.com (Postfix) with ESMTP id CEDFD18235; Tue, 12 Sep 2006 14:01:05 +0300 (EEST) Date: Tue, 12 Sep 2006 14:01:05 +0300 From: Ion-Mihai Tetcu To: John Baldwin Message-ID: <20060912140105.22e7c9e3@it.buh.tecnik93.com> In-Reply-To: <200609112220.k8BMKbfG009489@repoman.freebsd.org> References: <200609112220.k8BMKbfG009489@repoman.freebsd.org> X-Mailer: Sylpheed-Claws 2.4.0 (GTK+ 2.8.20; i386-portbld-freebsd6.1) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/smbus smbus.c src/sys/kern bus_if.m X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Sep 2006 11:01:07 -0000 On Mon, 11 Sep 2006 22:20:37 +0000 (UTC) John Baldwin wrote: > jhb 2006-09-11 22:20:37 UTC > > FreeBSD src repository > > Modified files: > sys/dev/smbus smbus.c > sys/kern bus_if.m > Log: > - Revert making bus_generic_add_child() the default for > BUS_ADD_CHILD(). Instead, we want busses to explicitly specify an > add_child routine if they want to support identify routines, but by > default disallow having outside drivers add devices. > - Give smbus(4) an explicit bus_add_child() method. Might it have anything with this ? ===> i2c/controllers/viapm (all) cc -O2 -pipe -DVIAPM_BASE_ADDR=0x6000 -fno-strict-aliasing -Werror -D_KERNEL -DKLD_MODULE -std=c99 -nostdinc -I- -DHAVE_KERNEL_OPTION_HEADERS -include /usr/obj/usr/src/sys/ORION_U_P_O/opt_global.h -I. -I@ -I@/contrib/altq -finline-limit=8000 --param inline-unit-growth=100 --param large-function-growth=1000 -fno-common -g -I/usr/obj/usr/src/sys/ORION_U_P_O -mno-align-long-strings -mpreferred-stack-boundary=2 -mno-mmx -mno-3dnow -mno-sse -mno-sse2 -mno-sse3 -ffreestanding -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual -Wundef -fformat-extensions -c /usr/src/sys/modules/i2c/controllers/viapm/../../../../pci/viapm.c In file included from /usr/src/sys/modules/i2c/controllers/viapm/../../../../pci/viapm.c:54: @/dev/smbus/smbus.h:34: error: field `lock' has incomplete type *** Error code 1 -- IOnut - Un^d^dregistered ;) FreeBSD "user" "Intellectual Property" is nowhere near as valuable as "Intellect" The joys of love made her human and the agonies of love destroyed -- Spock, "Requiem for Methuselah", stardate 5842.8