From owner-freebsd-rc@FreeBSD.ORG Mon Dec 26 09:02:38 2011 Return-Path: Delivered-To: freebsd-rc@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D8331106564A; Mon, 26 Dec 2011 09:02:38 +0000 (UTC) (envelope-from yanegomi@gmail.com) Received: from mail-gx0-f182.google.com (mail-gx0-f182.google.com [209.85.161.182]) by mx1.freebsd.org (Postfix) with ESMTP id 58CF08FC0C; Mon, 26 Dec 2011 09:02:38 +0000 (UTC) Received: by ggnp1 with SMTP id p1so10826280ggn.13 for ; Mon, 26 Dec 2011 01:02:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=subject:mime-version:content-type:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to:x-mailer; bh=VIfOKcGnXxXzSCNFVxnlTJOj2ykYUF6fdiVTFAjL3Uw=; b=DgETyr6iIu1r3bLqcR/4iRFL2XBaN5G9qZlZZ4Yq/Dq4IRXfucwVoKBjRQabuJtTr7 QHloo17rHIkr3VSJQTn4pemq/VlyKQRGD3sCQ6TGXl/OgkJx+qCXCNA3Z/MGz8yaXG4k DdqIacq1s0YehM5Bhb2Drj0oFzksz0D9o8ZJs= Received: by 10.101.24.16 with SMTP id b16mr9762976anj.36.1324890157515; Mon, 26 Dec 2011 01:02:37 -0800 (PST) Received: from [192.168.2.5] (dpc691944246.direcpc.com. [69.19.44.246]) by mx.google.com with ESMTPS id c10sm33939688yhj.2.2011.12.26.01.02.21 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 26 Dec 2011 01:02:36 -0800 (PST) Mime-Version: 1.0 (Apple Message framework v1251.1) Content-Type: text/plain; charset=windows-1252 From: Garrett Cooper In-Reply-To: <4EF833B7.9040704@FreeBSD.org> Date: Mon, 26 Dec 2011 01:02:06 -0800 Content-Transfer-Encoding: quoted-printable Message-Id: <0A59E5CD-3598-41B0-A707-6C5185E80043@gmail.com> References: <4EF6401E.3080902@FreeBSD.org> <20111224215649.GA12789@stack.nl> <4EF80CA7.3070303@FreeBSD.org> <4EF82E3B.6040601@FreeBSD.org> <4EF833B7.9040704@FreeBSD.org> To: Doug Barton X-Mailer: Apple Mail (2.1251.1) Cc: Pyun Yong-Hyeon , d@delphij.net, Eygene Ryabinkin , Gleb Smirnoff , freebsd-rc@freebsd.org Subject: Re: Annoying ERROR: 'wlan0' is not a DHCP-enabled interface X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Dec 2011 09:02:38 -0000 On Dec 26, 2011, at 12:43 AM, Doug Barton wrote: > On 12/26/2011 00:40, Eygene Ryabinkin wrote: >> Doug, how that can be a failure? >=20 > How does anything fail? Isn't that why you call it a "failure" instead > of a "success?" >=20 > But if Gleb is right and the problem is new to HEAD, when did it = change, > and why? 226879 rea if [ -z "${rc_force}" ] && ! dhcpif $ifn; then 226879 rea err 1 "'$ifn' is not a DHCP-enabled = interface" 226879 rea fi $ svn log -r 226879 ------------------------------------------------------------------------ r226879 | rea | 2011-10-27 23:03:38 -0700 (Thu, 27 Oct 2011) | 10 lines Fix handling of rc_force in /etc/rc.d/dhclient Variable 'rc_force' is accessible only at the time of rc_run_command, so it can't be examined from the script's main code. Spotted by: hrs Reviewed by: hrs, des Approved by: des MFC after: 2 weeks ------------------------------------------------------------------------ It simply didn't exist before this change; before it was just a 'return = 1', which is illegal outside of functions, amongst other things. So I vote to just remove the message (convert the err 1 to a exit 1) and = MFC back to 9.0=85 please, because this change is present there now. We can argue about the semantics of rc_quiet later. Tons of people just = care about the fact that the message is showing up and don't really care = about the semantics. Thanks, -Garrett=