Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 18 Mar 2004 12:50:56 +0100
From:      des@des.no (Dag-Erling =?iso-8859-1?q?Sm=F8rgrav?=)
To:        Marcel Moolenaar <marcel@xcllnt.net>
Cc:        current@FreeBSD.org
Subject:   Re: [current tinderbox] failure on ia64/ia64
Message-ID:  <xzpu10m5q73.fsf@dwp.des.no>
In-Reply-To: <20040318084128.GA59199@dhcp01.pn.xcllnt.net> (Marcel Moolenaar's message of "Thu, 18 Mar 2004 00:41:28 -0800")
References:  <20040317040254.386947303A@freebsd-current.sentex.ca> <xzpad2fhixn.fsf@dwp.des.no> <20040317113931.GF49920@ip.net.ua> <20040317200307.GA46126@ip.net.ua> <20040317205104.GA29066@dhcp01.pn.xcllnt.net> <20040317213014.GB46747@ip.net.ua> <20040318084128.GA59199@dhcp01.pn.xcllnt.net>

next in thread | previous in thread | raw e-mail | index | archive | help
Marcel Moolenaar <marcel@xcllnt.net> writes:
> The source code appears to be fishy. The variable v is never used.
> It's only defined. If you change the "return mask" to a "return v",
> the warning goes away.

I suspect that there's a line missing:

@@ -548,4 +548,5 @@
        }
        DEB(printf("sv_mix_setrecsrc: mask 0x%08x adc_input 0x%02x\n", mask=
, v));
+       sv_indirect_set(sc, SV_REG_ADC_INPUT, v);
        return mask;
 }

although I have no way of testing this.

DES
--=20
Dag-Erling Sm=C3=B8rgrav - des@des.no



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?xzpu10m5q73.fsf>