From nobody Tue Feb 3 21:16:49 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4f5GWl3Vfsz6QlVc; Tue, 03 Feb 2026 21:16:51 +0000 (UTC) (envelope-from markj@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4f5GWl2mn5z3tPJ; Tue, 03 Feb 2026 21:16:51 +0000 (UTC) (envelope-from markj@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1770153411; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=0QBtDf+1H1OHQqTP+ex/z3j4FLrbjdwAo7Ya7BGxUN8=; b=iGCwbt5hMUtECoCgYbLKQNOtH4JmmPBs1kVHm934zVW7AUeFovonucY+95Ljt8ndUFs5S4 ztAE5fBY48ywnMfUVCa7qpeVqq5Yq8FrO1uYwlcrQQ2Wf0GypdXJ7eYNzvYA1i8Me5goHC TogYb5/RBdwJS2Mm2qsM0UJGNcKNIqjpSHyIAnlKu5HiiSPTfoM12uGSdH0bB1mFYaNMd/ ZRVKCfKAMcKo8oFUz6f1aqNbH0cqcTgbjdIH2rAFZCk4TULEgp3rwj5f3UD4t/X2m9QXe6 nnYq9V6+h+wpX2c+yz6OeRmRAMh9h701U6KJPaKwY2iE2hb0kib4pzYz9pjU9g== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1770153411; a=rsa-sha256; cv=none; b=rJgqIc6LQxBkfYELdX7TRYM0ZoZ8aLARVhry2BTzB392H7vcR9W7RseWGyLkk76WYqtKhE J/WzOHU/dU/K11jZewB/9xwnFaUzUIki1FGl1tPXI3uZE1dSxf/ASTKwyytZZi1nBkjoX3 9xbCpjGUrgcueLlzluBBQ8XcyYuN0B+k2PlOHSE6JRLGTFPKxJTG4eQJjHu6THMbCyYDpn 58P7VzlSm0sekhpxQL8g69x5SoFV6UIwWXebC3U+IFTQuwpgtVZjQ+t/ddbQ2tjGmdC2HA JYfOz0uJtmyUnP4n+rvWJU2X/7dKRXH9Hca52udxluF1RoWk+np7Bl7Te5tb6g== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1770153411; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=0QBtDf+1H1OHQqTP+ex/z3j4FLrbjdwAo7Ya7BGxUN8=; b=cUdp9kKIX5oJPs3PWBL1OhzCeFimR2ZYvK0Pe9Ifv5/USIsE48ZTS+PaA3ZcOyaPc0yHXw 8wQVfeKhD9UWT/AM9sXfuRIbcSjkn3PlLZeLU5NYE6uZXOEJ8NIYBGxd2WH3zj8vOQk9Pz w68FroFpFe3qbwhFYbY1pgjoGjesiHpqjEDQM0giDmU3Bh8KidwDWGvXRrzCjJPppmxVec /tKFN/YycBfze7fmeQbgOaN1k1eVAZlEmyvj8YtVTJNASWpqr3Guq+dcAW2m0clDVdCGpB ZfOpgtoZeh7I/kYH0GiZheAE3MkVNQ9jm3nRWrjWs0o8Dv5I6IaVXuh/xdFuLA== Received: from nuc (192-0-220-237.cpe.teksavvy.com [192.0.220.237]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: markj) by smtp.freebsd.org (Postfix) with ESMTPSA id 4f5GWl0Xssz4YL; Tue, 03 Feb 2026 21:16:51 +0000 (UTC) (envelope-from markj@freebsd.org) Date: Tue, 3 Feb 2026 16:16:49 -0500 From: Mark Johnston To: Gleb Smirnoff Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 349fcf079ca3 - main - net: add ifnet_rename_event EVENTHANDLER(9) for interface renaming Message-ID: References: <6948abb4.37a66.71609f61@gitrepo.freebsd.org> List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6948abb4.37a66.71609f61@gitrepo.freebsd.org> On Mon, Dec 22, 2025 at 02:23:48AM +0000, Gleb Smirnoff wrote: > The branch main has been updated by glebius: > > URL: https://cgit.FreeBSD.org/src/commit/?id=349fcf079ca32d5c93e45366d2b27638747affeb > > commit 349fcf079ca32d5c93e45366d2b27638747affeb > Author: Gleb Smirnoff > AuthorDate: 2025-12-21 21:31:43 +0000 > Commit: Gleb Smirnoff > CommitDate: 2025-12-22 02:23:14 +0000 > > net: add ifnet_rename_event EVENTHANDLER(9) for interface renaming > > and don't trigger ifnet_arrival_event and ifnet_departure_event for a > rename, as the interface isn't being detached from any protocol. The > consumers of the arrival/departure events are divided into a few > categories: > - which indeed need to do the same actions as if interface was fully > detached and attached: routing socket and netlink notifications to > userland and the Linux sysfs. All addressed by this commit. > - which build their logic based on an interface name, but should actually > update their database on rename: packet filters. This commit leaves > them with the old behavior - emulate full detach & attach, but this > should be improved. > - which shouldn't do anything on rename, not touched by the commit. > - ng_ether and if_tuntap, that are special and will be addressed by > separate commits. Can we get rid of the IFF_RENAMING flag now? IIUC all of its uses are in ifnet_departure_event handlers to short-circuit the handler because the interface is not actually going away.