Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 06 Oct 2001 12:38:12 -0700
From:      Peter Wemm <peter@wemm.org>
To:        tlambert2@mindspring.com
Cc:        Kris Kennaway <kris@obsecurity.org>, Nate Williams <nate@yogotech.com>, Lyndon Nerenberg <lyndon@atg.aciworldwide.com>, Bernd Walter <ticso@mail.cicely.de>, current@FreeBSD.ORG
Subject:   Re: PATCHES for Kris Kennaway to commit 
Message-ID:  <20011006193812.D4C3A3808@overcee.netplex.com.au>
In-Reply-To: <3BBF584B.BA87E7ED@mindspring.com> 

next in thread | previous in thread | raw e-mail | index | archive | help
Terry Lambert wrote:

> After that, you can commit the patches to /sys/conf/param.c to
> make maxfiles and maxfilesperproc tunable at boot time, and the
> patches to login.c to make it possible to rebadge the "login:"
> and "password:" prompts, and the patches to /sys/netinet/udp_usrreq.c
> to make it so you can tune for a large number of TCP sokets
> without tuning for a large number of UDP sockets.


BZZZT!!  Try again.
peter@overcee[12:35pm]~/releng_4/sys/conf-110> ls param.c
ls: param.c: No such file or directory

param.c was moved to kern/subr_param.c and is fully dynamic, and already
has these changes.

TUNABLE_INT_DECL() should be TUNABLE_INT() and is using the old syntax.

If you're going to submit stuff, please at least do us the courtesy to make
sure it is relative to recent source trees.  This change was made quite some
time ago on both -current and RELENG_4.

FYI: kern/subr_param.c:
...
int     maxprocperuid;                  /* max # of procs per user */
int     maxfiles;                       /* sys. wide open files limit */
int     maxfilesperproc;                /* per-proc open files limit */
int     ncallout;                       /* maximum # of timer events */
...
        /* The following can be overridden after boot via sysctl */
        maxproc = NPROC;
        TUNABLE_INT_FETCH("kern.maxproc", &maxproc);
        maxfiles = MAXFILES;
        TUNABLE_INT_FETCH("kern.maxfiles", &maxfiles);
        maxprocperuid = maxproc - 1;
        maxfilesperproc = maxfiles;
...


> ***************
> *** 67,74 ****
>   #endif
>   int   maxproc = NPROC;                        /* maximum # of processes */
>   int   maxprocperuid = NPROC-1;                /* maximum # of processes per
     user */
> ! int   maxfiles = MAXFILES;                    /* system wide open files lim
    it */
> ! int   maxfilesperproc = MAXFILES;             /* per-process open files lim
    it */
>   int   ncallout = 16 + NPROC + MAXFILES;       /* maximum # of timer events 
    */
>   int   mbuf_wait = 32;                         /* mbuf sleep time in ticks *
    /
> 
> --- 69,78 ----
>   #endif
>   int   maxproc = NPROC;                        /* maximum # of processes */
>   int   maxprocperuid = NPROC-1;                /* maximum # of processes per
     user */
> ! int   maxfiles = 0;                   /* system wide open files limit */
> ! TUNABLE_INT_DECL("kern.maxfiles", MAXFILES, maxfiles);
> ! int   maxfilesperproc = 0;            /* per-process open files limit */
> ! TUNABLE_INT_DECL("kern.maxfilesperproc", MAXFILES, maxfilesperproc);
>   int   ncallout = 16 + NPROC + MAXFILES;       /* maximum # of timer events 
    */
>   int   mbuf_wait = 32;                         /* mbuf sleep time in ticks *
    /


Cheers,
-Peter
--
Peter Wemm - peter@FreeBSD.org; peter@yahoo-inc.com; peter@netplex.com.au
"All of this is for nothing if we don't go to the stars" - JMS/B5


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20011006193812.D4C3A3808>