From owner-p4-projects@FreeBSD.ORG  Fri Mar  9 14:37:38 2007
Return-Path: <owner-p4-projects@FreeBSD.ORG>
X-Original-To: p4-projects@freebsd.org
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 4486D16A402; Fri,  9 Mar 2007 14:37:38 +0000 (UTC)
X-Original-To: perforce@freebsd.org
Delivered-To: perforce@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 16C2416A401
	for <perforce@freebsd.org>; Fri,  9 Mar 2007 14:37:38 +0000 (UTC)
	(envelope-from piso@freebsd.org)
Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41])
	by mx1.freebsd.org (Postfix) with ESMTP id F29BF13C4A7
	for <perforce@freebsd.org>; Fri,  9 Mar 2007 14:37:37 +0000 (UTC)
	(envelope-from piso@freebsd.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id l29EbbE1057813
	for <perforce@freebsd.org>; Fri, 9 Mar 2007 14:37:37 GMT
	(envelope-from piso@freebsd.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.13.6/8.13.4/Submit) id l29EbbW5057810
	for perforce@freebsd.org; Fri, 9 Mar 2007 14:37:37 GMT
	(envelope-from piso@freebsd.org)
Date: Fri, 9 Mar 2007 14:37:37 GMT
Message-Id: <200703091437.l29EbbW5057810@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	piso@freebsd.org using -f
From: Paolo Pisati <piso@FreeBSD.org>
To: Perforce Change Reviews <perforce@freebsd.org>
Cc: 
Subject: PERFORCE change 115603 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 09 Mar 2007 14:37:38 -0000

http://perforce.freebsd.org/chv.cgi?CH=115603

Change 115603 by piso@piso_newluxor on 2007/03/09 14:37:29

	o Remove the last vestige of interrupt stray handling.
	o Style and spacing.
	o Reduce diff against HEAD.

Affected files ...

.. //depot/projects/soc2006/intr_filter/kern/kern_intr.c#37 edit

Differences ...

==== //depot/projects/soc2006/intr_filter/kern/kern_intr.c#37 (text+ko) ====

@@ -58,9 +58,6 @@
 #include <ddb/db_sym.h>
 #endif
 
-/* MD function */
-extern void intr_callout_reset(void);
-
 /*
  * Describe an interrupt thread.  There is one of these per interrupt event.
  */
@@ -96,11 +93,12 @@
 
 static void	intr_event_update(struct intr_event *ie);
 static struct intr_thread *ithread_create(const char *name, 
-					  struct intr_handler *ih);
+			      struct intr_handler *ih);
 static void	ithread_destroy(struct intr_thread *ithread);
-static void	ithread_execute_handlers(struct proc *p, struct intr_event *ie);
+static void	ithread_execute_handlers(struct proc *p, 
+		    struct intr_event *ie);
 static void	priv_ithread_execute_handler(struct proc *p, 
-					     struct intr_handler *ih);
+		    struct intr_handler *ih);
 static void	ithread_loop(void *);
 static void	ithread_update(struct intr_thread *ithd);
 static void	start_softintr(void *);
@@ -718,21 +716,21 @@
 			continue;
 
 		/*
-                 * For software interrupt threads, we only execute
-                 * handlers that have their need flag set.  Hardware
-                 * interrupt threads always invoke all of their handlers.
-                 */
-                if (ie->ie_flags & IE_SOFT) {
-                        if (!ih->ih_need)
-                                continue;
-                        else
-                                atomic_store_rel_int(&ih->ih_need, 0);
-                }
+		 * For software interrupt threads, we only execute
+		 * handlers that have their need flag set.  Hardware
+		 * interrupt threads always invoke all of their handlers.
+		 */
+		if (ie->ie_flags & IE_SOFT) {
+			if (!ih->ih_need)
+				continue;
+			else
+				atomic_store_rel_int(&ih->ih_need, 0);
+		}
 
 		/* Execute this handler. */
 		CTR6(KTR_INTR, "%s: pid %d exec %p(%p) for %s flg=%x",
-		    __func__, p->p_pid, (void *)ih->ih_handler, ih->ih_argument,
-		    ih->ih_name, ih->ih_flags);
+		    __func__, p->p_pid, (void *)ih->ih_handler, 
+		    ih->ih_argument, ih->ih_name, ih->ih_flags);
 
 		if (!(ih->ih_flags & IH_MPSAFE))
 			mtx_lock(&Giant);