From nobody Tue May 24 18:10:07 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id B6C401B51DC5; Tue, 24 May 2022 18:10:09 +0000 (UTC) (envelope-from se@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4L72Ks4LsRz3n9j; Tue, 24 May 2022 18:10:09 +0000 (UTC) (envelope-from se@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1653415809; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Z7pGjUwMlqPh4dnAyJozNBi75a2kWlVISWuIidk3jeI=; b=pxAmCVLW/snUqZ3UB4PDJVrxJor0KohTfkamwzC5lt5mBTNIVAMSKP9uX8NbJGnwC2vGJb meA0qYn6Ps2bphTsGKuEzv1c0lmW7aepvhAeMDZEJA6BeW49hg6GlHvPmPsk5+zecMNGGZ YC2NC7edRs27NXwROBZ2gSWSpyGQqQd7nZhoyGkw7h73lyPJvkBRkdhY1IOOgKZzA11BSf r/2rFPCw+BmzBlOirDPk5c8vTjifQxM6o26s5blxdtamxJ8B5TSKKz4cDALW15/rMjQUdG VHSP99MzAQkd9lAO2N81RyjBLSDvw+E/AUXhnYx5NZKLMeX58EwX11FEkJSeUA== Received: from [IPV6:2003:cd:5f12:400:688d:b306:d02:dad9] (p200300cd5f120400688db3060d02dad9.dip0.t-ipconnect.de [IPv6:2003:cd:5f12:400:688d:b306:d02:dad9]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) (Authenticated sender: se/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id CC4561B5E; Tue, 24 May 2022 18:10:08 +0000 (UTC) (envelope-from se@FreeBSD.org) Message-ID: Date: Tue, 24 May 2022 20:10:07 +0200 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: git: 81cea61f3b3a - main - bin/sleep: document more non-standard features Content-Language: en-US To: Mike Karels Cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org References: <202205240933.24O9XPv8015486@gitrepo.freebsd.org> From: Stefan Esser In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------ZfIEy2jfn0k02XHZM4a0j0U2" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1653415809; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Z7pGjUwMlqPh4dnAyJozNBi75a2kWlVISWuIidk3jeI=; b=IcKVMhYQ+3ca3mU++sBf2Zf5wtvfFoB1IuPHrKTYMO1Hyu0sLBIf7HiXltQKGHoinfN/ok OhktkrIn4JU+VA8eXphMdIDGVZrDBx6tDUKw5PLzMr5+jPu7tlNdE+f68azcPoelWZs4tD 4OdTrCRg2NB3TgxytshfUPpkFHCSnA2W4bBHnbWCd5jQevfsOxe7cbheSkkbFHi7FsovMs eBuqKEHUrALJ/Fd3vmCWM6gaF0joX8OlkK90wR0kl9qb59qQeD3tC1ajc1VoWy2Ez6J4Tq q4j+seBRX42nzCmGckzikUyu+nushm81Fi0AOfB9mCgrTox7OdTat7HmLpC8xw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1653415809; a=rsa-sha256; cv=none; b=PDTrrZ0I+AkRmufFHRbEfb9vRA2eEiA6SuIONbr2nR+M22VukKOJpEI2nH5ssMwbKUfgNb wha3qQpI01JPhyti0gsMGO2ulVae0cXOhtKQhgITtitbSEelxbCirb2UPtjC1GngePp9+g 98GTJyEqktri2nKOxZgeq6sU0YInls5uC0KfKDlBTrAumqjiMxclusdGPUrU/26Exg8oir DOYXe5yB8QMyOAlapBS6BZPotmdSSXmGrc/+GkGQ6HFLrf/DxfDujpjYKXIifCBVg/zS/I VecXqAySws/Bf3va910bEGqAXCSQtRuqO0O2+poX1oCeOE+GQ6mc4j8DmNMgGg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------ZfIEy2jfn0k02XHZM4a0j0U2 Content-Type: multipart/mixed; boundary="------------sqAgmYhA0hKUXLUZopr8Jw30"; protected-headers="v1" From: Stefan Esser To: Mike Karels Cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Message-ID: Subject: Re: git: 81cea61f3b3a - main - bin/sleep: document more non-standard features References: <202205240933.24O9XPv8015486@gitrepo.freebsd.org> In-Reply-To: --------------sqAgmYhA0hKUXLUZopr8Jw30 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Am 24.05.22 um 14:24 schrieb Mike Karels: > On 24 May 2022, at 4:33, Stefan E=C3=9Fer wrote: >=20 >> diff --git a/bin/sleep/sleep.1 b/bin/sleep/sleep.1 >> index 85086acec5ad..f7da87152f99 100644 >> --- a/bin/sleep/sleep.1 >> +++ b/bin/sleep/sleep.1 >> @@ -70,9 +70,10 @@ signal is not handled specially by this implementat= ion. >> .Pp >> The >> .Nm >> -command allows and honors a non-integer number of seconds to sleep >> -in any form acceptable by >> -.Xr strtod 3 and it accepts more than one delay value. >> +command supports other time units than seconds, >> +honors a non-integer number of time units to sleep in any form accept= able by >> +.Xr strtod 3 , >> +and accepts more than one delay value. >> These are non-portable extensions, but they have also been implemente= d >> in GNU sh-utils since version 2.0a (released in 2002). >> .Sh EXIT STATUS >=20 > Is there a reason you didn=E2=80=99t list the time units that are suppo= rted? > It would also be good to say how they are specified. Commit 34978f7edd has already added the following text to the man page: --- a/bin/sleep/sleep.1 +++ b/bin/sleep/sleep.1 @@ -40,13 +40,21 @@ .Nd suspend execution for an interval of time .Sh SYNOPSIS .Nm -.Ar seconds +.Ar number[unit] .Sh DESCRIPTION The .Nm command suspends execution for a minimum of -.Ar seconds . +.Ar number +seconds (the default, or unit +.Ar s ) , +or minutes (unit +.Ar m ) , +hours (unit +.Ar h ) , +or days (unit +.Ar d ) . .Pp If the .Nm The rendered man page section reads: SYNOPSIS sleep number[unit] ... DESCRIPTION The sleep command suspends execution for a minimum of number seconds= (the default, or unit s), minutes (unit m), hours (unit h), or days (unit= d). If multiple arguments are passed, the delay will be the sum of all values. The first line of the description has been proposed in PR 264162 with the= patch that added support of units other than seconds. Support of multiple arguments has been added by me after noticing that th= is would make the FreeBSD sleep(1) support the same functionality as offered= by the coreutils version. The commit you replied to has just added the two new features to the IMPLEMENTATIION NOTES section in order to complete the list of non-standa= rd features offered after the two functional extensions. Regards, STefan --------------sqAgmYhA0hKUXLUZopr8Jw30-- --------------ZfIEy2jfn0k02XHZM4a0j0U2 Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEo3HqZZwL7MgrcVMTR+u171r99UQFAmKNH38FAwAAAAAACgkQR+u171r99USI wQf7BW47STwCVu1ljHj6bShmG0P4AWblK2GtC6gEeYqkB9NDIux7xDrhMw/k2MqAPuMh+NIzpWWl TbsEfUUu/ip/vwcv2rwC+r3a1Lc03dii/SG9FtUe38yPSC5M+vLmP2QJ141wY7la6dJAibs0Tae0 OfTdlbajh1NlDd/AM4jXsa/iYsXBWKokuS5XKdggV3j01aGWrH/45sd0LXwVa0WyGIqAJp/AuZmc KjurmQepjSg97Hz80zslF/Rh5itonexaiN4dPpuJH1St+YvgYzkc816GwqQwYvDVd8qtH9za35ej Hxq69v8dLYIKOVr4QG6jkhkjYd6pych88j7mqHTVag== =kPiG -----END PGP SIGNATURE----- --------------ZfIEy2jfn0k02XHZM4a0j0U2--