From owner-freebsd-bugs@FreeBSD.ORG Mon Aug 18 13:30:05 2008 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B7C791065676 for ; Mon, 18 Aug 2008 13:30:05 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id A2C9C8FC0A for ; Mon, 18 Aug 2008 13:30:05 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.2/8.14.2) with ESMTP id m7IDU543096423 for ; Mon, 18 Aug 2008 13:30:05 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.2/8.14.1/Submit) id m7IDU5jk096420; Mon, 18 Aug 2008 13:30:05 GMT (envelope-from gnats) Date: Mon, 18 Aug 2008 13:30:05 GMT Message-Id: <200808181330.m7IDU5jk096420@freefall.freebsd.org> To: freebsd-bugs@FreeBSD.org From: Pav Lucistnik Cc: Subject: Re: bin/124353: cvsup(1): CVSup coredumps with Bus Error since installworld of 6.3-STABLE on 28/5/08 [regression] X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Pav Lucistnik List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Aug 2008 13:30:05 -0000 The following reply was made to PR bin/124353; it has been noted by GNATS. From: Pav Lucistnik To: Joseph Koshy Cc: bug-followup@FreeBSD.org, srp@zzap.org Subject: Re: bin/124353: cvsup(1): CVSup coredumps with Bus Error since installworld of 6.3-STABLE on 28/5/08 [regression] Date: Mon, 18 Aug 2008 15:21:31 +0200 > On 24-Apr-08 changes needed to support kernel mode NFS locking were > MFC'ed to RELENG_6. As part of this change, the semantics of fcntl() > were extended. In order to deal with older binaries, the > implementation of fcntl() in "lib/libc" was changed from a direct > system call to a varargs wrapper: __fcntl_compat(). > > Binary calling conventions for varargs and ordinary functions differ > on the AMD64. In particular callers of varargs functions use the %al > register to pass in a 'hidden' value to the callee. > > So the changes needed to unbreak Modula-3/CVSup are: > > 1) Augment the M3 definition of 'struct flock' with a new l_sysid > field; this should be harmless on older, pre-NFS-kernel-locking > systems. > > 2) Despatch M3's "fcntl" to a C function "ufcntl" that translates > between the two calling conventions. > > The following patch implements the fix. Since it stacks over pav@'s > amd64 patch set, it needs to be applied after first running 'make > patch' and before a subsequent 'make install'. > > pav@, maintainer of the CVSup/AMD64 patch set is CC'ed. Thanks, this fixes the crashes for me. I will update the port today. -- Pav Lucistnik The Novice rogue. A rather shifty individual